Repository navigation
Implement human-readable serde deserialization for TimezonePeriods - #8554
Open
Manishearth wants to merge 2 commits into
Open
Manishearth wants to merge 2 commits into
Manishearth wants to merge 2 commits into
Conversation
Manishearth
changed the title
Member
Author
|
@robertbastian the lack of this prevents serde-json roundtrip for TimezonePeriodsV1, but this is also a fair amount of agent-generated code. Not sure if there's a better way to do this. Thoughts? |
Manishearth
force-pushed
the
fix-timezone-periods-serde
branch
from
October 6, 2026 23:18
ff103fe to
3602c1a
Compare
|
🎉 All dependencies have been resolved ! |
Manishearth
force-pushed
the
fix-timezone-periods-serde
branch
2 times, most recently
from
October 7, 2026 22:47
25b1517 to
787ee4b
Compare
…zonePeriods Implement TimezonePeriods::deserialize for human-readable deserializers (see unicode-org#6752), reconstructing the deduplicated offsets table, ZeroTrieSimpleAscii time zone index, and VarZeroVec period list from the human-readable map produced by TimezonePeriods::serialize.
Manishearth
marked this pull request as ready for review
October 7, 2026 23:00
Manishearth
requested review from
nekevss,
robertbastian and
sffc
as code owners
October 7, 2026 23:00
Manishearth
force-pushed
the
fix-timezone-periods-serde
branch
from
October 7, 2026 23:01
787ee4b to
8021563
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #8552 and #8553
Needs moving some datagen code to the crate since it's useful for construction.
cc #6752, since the TODO mentioned it (but this doesn't actually fix that issue)
Changelog
icu_time: Implement human-readable serde deserialization for TimezonePeriods