docs-app: restore site styling layer, add page-walking a11y tests - #22
Merged
NullVoxPopuli merged 2 commits intoJul 20, 2026
Merged
Conversation
The deployed site rendered with browser-default (serif) typography and a theme toggle that changed nothing visible: docs-support's Shell brings the structural site CSS, but the app itself is responsible for the layer ember-primitives' docs-app defines in app.css — the reset, the --font-sans stack + body font-family, prose/typedoc overrides, and the .theme-light/.theme-dark variables the chrome reads. Ported that layer (verified in a browser: sans-serif typography and a working visible theme toggle). Also port ember-primitives' docs-app test setup: - an application test walks every page in the kolay manifest, runs an axe-core audit per page in default/dark/light themes (color-contrast off, matching primitives), and asserts no [data-page-error] — which is exactly the signal for a live demo failing to compile/render - testem with ember-a11y-testing's middleware reporter, vite build --mode development + testem ci - root `pnpm test` now runs all workspace test tasks; the try-scenario job stays scoped to test-app (scenarios only vary its deps) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The middleware reporter writes a JSON report per test run; two of them were swept into the previous commit and failed prettier in CI. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
NullVoxPopuli
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the broken CSS/behavior on https://ue-form.pages.dev/ and adds the docs-app test suite in ember-primitives' style.
The bug
docs-support's
Shellimports the structural site CSS itself, but the app owns the layer primitives defines in its ownapp.css— the CSS reset, the--font-sansstack andbody { font-family }, prose/typedoc overrides, and crucially the.theme-light/.theme-darkcustom-property definitions the chrome reads. I had only carried over the typedoc/demo styles, so the deployed site fell back to browser-default serif typography ("CSS broken") and the theme toggle toggled classes that defined nothing ("behavior broken").Ported that layer and verified in a real browser against the production build: sans-serif typography everywhere and the toggle now visibly flips light/dark.
Tests (ported from ember-primitives)
color-contrastdisabled, matching primitives), and asserts no[data-page-error]— kolay renders that marker when a live demo fails to compile, so broken demos now fail CI.ember-a11y-testing's middleware reporter;vite build --mode development && testem ci.pnpm testnow runs all workspace test tasks, so the Default Tests and Floating Deps jobs cover docs-app; the try-scenarios job stays scoped to--filter test-app(scenarios only vary test-app's dependencies).All pages currently pass the audit (163-assertion run, ~7s locally).
Full
turbo build lint test typecheck: 16/16 green.🤖 Generated with Claude Code