Skip to content

Exclude React-version selection glue from coverage (fix codecov/patch on master) #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adeelraza merged 1 commit into from
Aug 11, 2026
Merged

Exclude React-version selection glue from coverage (fix codecov/patch on master) #516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/EmailEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,18 @@ const useCounterEditorId = (): string =>
// mismatch that otherwise leaves the editor mounting against a stale server id
// (blank editor) under SSR/Next.js. The implementation is picked once at module
// load (stable for the app's lifetime), so the same hook runs on every render.
//
// v8 ignore: this is React-version selection glue. The two arms are covered by
// separate suites (useId by the React 18/19 tests, the counter by the React
// 16/17 smoke suite) but never within a single coverage run, so the untaken
// arm always reads as a partial branch.
/* v8 ignore start */
const useGeneratedEditorId: () => string =
typeof React.useId === 'function'
? // Strip ':' so the id is a valid CSS selector for unlayer.createEditor.
() => `editor-${React.useId().replace(/:/g, '')}`
: useCounterEditorId;
/* v8 ignore stop */

function EmailEditorInner<
TDisplayMode extends DisplayMode | undefined = 'email',
Expand Down