fix(mover): use a widely supported arrow for the Mover direction label - #2705
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe Share settings mover direction dropdown replaces the ChangesMover Direction Labels
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Small ping on this one. It swaps U+2B95 for U+2192 in the Mover direction labels in ShareEdit.page, which is the tofu box in #2545, open since February. Six lines in one file and CodeRabbit found nothing; happy to rebase, or close it if you'd rather fix this on the font side. |
Fixes #2545.
The Mover direction options in Share Settings use
⮕(U+2B95), which is missing from many system fonts and renders as a tofu box. Replacing it with→(U+2192), which is universally available, keeps the same meaning and renders everywhere.The label is set via jQuery
.text(), so a literal character is used rather than an HTML entity.Summary by CodeRabbit