fix: don't cache question.png fallback as a resolved icon

[Swindles McCoop (swindlesmccoop)]

Fixes #2713

Summary by CodeRabbit

• Bug Fixes
  • Improved Docker icon handling by refreshing icons when cached data contains the shared fallback icon.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d4c11999-2f51-4ce3-8d9f-95aedd826ea9

📥 Commits

Reviewing files that changed from the base of the PR and between 8d40212 and b08c96f.

📒 Files selected for processing (1)

• emhttp/plugins/dynamix.docker.manager/include/DockerClient.php

---

Walkthrough

The Docker icon cache now treats the shared question-mark fallback as invalid cached data. Container information refreshes can therefore resolve a newly available icon.

Changes

Docker icon cache refresh

Layer / File(s)	Summary
Fallback icon validation emhttp/plugins/dynamix.docker.manager/include/DockerClient.php	DockerTemplates::getAllInfo no longer treats the shared question-mark icon as a valid cached icon during container refreshes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

• unraid/webgui#2693: Both PRs modify Docker icon fallback and cache handling in DockerClient.php.
• unraid/webgui#2709: Both PRs modify Docker icon fallback handling in separate code paths.

Suggested labels: 7.3.3

Poem

A bunny found a cached icon bright,
A question mark that blocked new light.
“Try again,” the refresh said,
“Let the proper icon be read.”
Hop, hop—the Docker shelf looks right!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: preventing question.png fallback icons from being cached as resolved icons.
Linked Issues check	✅ Passed	The change meets issue #2713 by treating the question-mark fallback as invalid cached data so valid icons can resolve later.
Out of Scope Changes check	✅ Passed	The one-line change is directly related to issue #2713 and introduces no unrelated scope.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}