fix(boot): backport mounted usage stats to 7.3 - #2740
Conversation
Restore row-level filesystem rendering to use mount status so mounted boot partitions keep their used/free statistics when the array is stopped. Keep the existing stopped-state guard in my_usage() for the aggregate navigation widget and cover mounted boot versus unmounted data partitions. Refs: https://linear.app/lime-technology/issue/OS-852/740-beta12-regression-boot-device-usedfree-stats-missing-when-array-is
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔧 PR Test Plugin AvailableA test plugin has been generated for this PR that includes the modified files. Version: 📥 Installation Instructions:Install via Unraid Web UI:
Alternative: Direct Download
|
Summary
The 7.3.3 release-line backport restores used/free statistics for mounted boot partitions while keeping the aggregate navigation usage widget
offlinewhen the array is stopped.Why This Exists
The
7.3branch already contains the stopped-array utilization change from OS-804. Its array-state check also suppresses valid row-level statistics for a mounted boot partition, even though the corresponding data partition can be unmounted and should remain status-only. This backport addresses the OS-852 regression on the 7.3.3 release line.Resolution
Keep the stopped-state guard in
my_usage(), which owns the navigation widget, and restorefs_info()to use filesystem mount status as its row-level display contract. Mounted filesystems render their supplied used/free values regardless of array state; unmounted filesystems render status text. This is the targeted release-line equivalent of PR #2739.Reviewer Considerations
7.3, the branch carrying the 7.3.3 release line.fs_info()intentionally does not inspectfsState; the filesystem status distinguishes a mounted boot partition from an unmounted data partition.device_listand the existing regression test; it does not alter the already-backported navigation behavior.Behavior Changes
offlineinstead of a navigation usage percentage.Implementation Summary
fs_info()to gate usage onfsStatus == Mountedonly.Verification
php tests/stopped-array-utilization.php— passed.php -l emhttp/plugins/dynamix/nchan/device_list— passed.php -l emhttp/plugins/dynamix/include/Helpers.php— passed.php -l tests/stopped-array-utilization.php— passed.git diff --check— passed.Risk
Low; the change restores the existing mount-status contract and leaves the stopped-array navigation guard unchanged.
Linear
Related to OS-852.