Skip to content

Stale TODO comment in firecracker.go claims block device support is missing #1013

Description

@magic-peach

In pkg/unikontainers/hypervisors/firecracker.go, the block device setup code is preceded by:

// TODO: Add support for block devices in FIrecracker

The loop directly below this comment already builds FirecrackerDrive entries from ukernel.MonitorBlockCli(), including marking the root device, so block device support is already implemented. The docs also list Firecracker with block/devmapper support. The comment is just stale and should be removed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions