Conversation
Signed-off-by: Norway-02 <anshulkhetade02@gmail.com>
✅ Deploy Preview for urunc canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind bug
Rationale
In Kubernetes and containerized environments, network interface names created by host systems or CNI plugins often contain
"tap"as a substring (e.g.bootstrap0,vtap0,cni-tap0,stape0).Currently,
getTapIndex()inpkg/network/network.gochecks:When
DynamicNetwork.NetworkSetup()runs during container creation, iftapIndex > 0,uruncaborts container launch with:unsupported operation: can't spawn multiple unikernels in the same network namespaceThis causes
uruncto falsely believe a unikernel is already running and refuse to spawn the first container whenever any interface with"tap"in its name exists in the network namespace.This PR updates
getTapIndex()to use the regex pattern^tap\d+(_urunc)?$, matchingurunc's own TAP device naming convention while ignoring unrelated host/CNI interfaces.Fixes #938
Reviewer Notes
TestGetTapIndexandTestTapDeviceRegexMatchinginpkg/network/network_test.go.LLM usage
none