Repository navigation
feat(vulns): add close and reopen commands and --status filter - #344
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Current Aviator status
This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
tjdammann
temporarily deployed
to
integration-tests
November 4, 2026 00:28 — with
GitHub Actions
Inactive
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tjdammann
marked this pull request as ready for review
November 4, 2026 20:53
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds close and reopen for vulns, matching
detail bugs. The commands' API ships in usedetail/detail #19512, withtrackerStateNamefrom #19513.Do not merge until those PRs have deployed.
stateis a new required field onVuln, so this CLI should fail to parsevulns listandvulns showfrom an older backend. This is a draft for that reason.cargo xtask checkfails onopenapi.jsonuntil then, which is expected because it compares against production's spec.What changed
detail vulns close <id>:--state,--dismissal-reason,--notesand--format, with the same prompts and non-interactive validation asbugs close.detail vulns reopen <id>: takes only the ID.vulns list --status: one value. Without it the API defaults topending, so closed vulns are hidden unless you ask.listadds State and Dismissal.showalso adds Notes, State Source and State Updated, which explain a tracker dismissal with no reason.openapi.json: regenerated from a local backend's spec (165 additions, no removals). xtask is unchanged.docs/HELP.mdand the bundleddetail-bugsskill.bugs.rs:prompt_notesbecomespub(crate). No other bugs change.--statustakes one value wherebugs listtakes several, because the API takes one. Reason flags are kebab-case, likenot-a-bug.After the backend deploys
cargo xtask generate-openapiand confirm the diff is empty or expected.cargo xtask check, which should then pass.Testing
Against the backend stack on a fork of prod, with a debug binary and an isolated config:
bugsclose, reopen, show and list unchanged.cargo fmt, clippy, check and test pass. Live-API integration tests return early without a key, so those don't all really run.Not run: this CLI against a backend without the new API, and
showon a tracker-set state name (unit test only).🤖 Generated with Claude Code