Repository navigation
feat: sign in with GitHub - #41
Merged
Merged
Conversation
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://feat-github-login-kanban-web.ut-code.workers.dev (commit f73b3ac)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
…registered up to ten
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2
ログインに GitHub OAuth を追加する (Google ではなく GitHub にした)。キーを入れるまでは、ボタンは出ない。 GitHub の OAuth App の作成と、本番へのキーの設定は、まだ。
仕組み
GITHUB_CLIENT_IDとGITHUB_CLIENT_SECRETの両方がある環境でだけ有効。環境の名前ではなく、設定の有無で分ける。ない環境 (ローカルで書いていないとき、プレビュー) では、ボタンが出ないGET /api/config({ github: true | false }、秘密は返さない) で、ボタンを出すかを決めるテスト
client_id、redirect_uri(<URL>/api/auth/callback/github)、user:emailの権限で作られる (better-auth のハンドラを通して確認。GitHub には接続しない)注意
docs を更新 (Web アプリ仕様、デプロイ、README、
.dev.vars.example)