Skip to content

Feat: Support appwrite oauth#202

Merged
Meldiron merged 1 commit into
mainfrom
feat-appwrite-oauth
Jun 30, 2026
Merged

Feat: Support appwrite oauth#202
Meldiron merged 1 commit into
mainfrom
feat-appwrite-oauth

Conversation

@Meldiron

Copy link
Copy Markdown
Contributor

No description provided.

@greptile-apps

greptile-apps Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds appwrite as a supported OAuth2 provider in the migration library's allow-list, enabling the clientId field to be migrated to the destination.

  • The appwrite entry is inserted between figma and fusionauth, breaking the alphabetical order maintained by the rest of the list — it should sit between amazon and apple.
  • All other self-hosted / multi-tenant OAuth providers (auth0, authentik, fusionauth, gitlab, keycloak, okta) include an endpoint field that carries the instance URL to the destination. The Appwrite provider likely needs the same, since Appwrite can be self-hosted at a custom domain; omitting it means the migrated provider will be non-functional on the destination without manual correction.

Confidence Score: 3/5

The change is small but likely incomplete — the missing endpoint field would leave the migrated Appwrite OAuth provider non-functional without manual intervention after migration.

The appwrite provider entry omits the endpoint field that every other self-hosted OAuth provider in the list includes, meaning the destination would have no way to reach the correct Appwrite instance. This is a functional gap in the migration, not just a style nit.

src/Migration/Resources/Auth/OAuth2/OAuth2Provider.php — verify whether Appwrite OAuth requires an endpoint and add it if so, and move the entry to its correct alphabetical position.

Important Files Changed

Filename Overview
src/Migration/Resources/Auth/OAuth2/OAuth2Provider.php Adds appwrite to PROVIDERS allow-list; entry is placed out of alphabetical order and likely missing a required endpoint field analogous to other self-hosted OAuth providers.

Comments Outside Diff (1)

  1. src/Migration/Resources/Auth/OAuth2/OAuth2Provider.php, line 28-29 (link)

    P2 The appwrite entry is inserted out of alphabetical order. The entire PROVIDERS list is sorted alphabetically, so appwrite should sit between amazon and apple, not between figma and fusionauth.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Reviews (1): Last reviewed commit: "Support appwrite oauth" | Re-trigger Greptile

Comment thread src/Migration/Resources/Auth/OAuth2/OAuth2Provider.php
Comment thread src/Migration/Resources/Auth/OAuth2/OAuth2Provider.php
@Meldiron Meldiron merged commit 9265561 into main Jun 30, 2026
4 checks passed
@Meldiron Meldiron deleted the feat-appwrite-oauth branch June 30, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant