Skip to content

Exercise mixed application capacity and recovery - #464

Merged
valthon merged 1 commit into
mainfrom
codex/mixed-application-capacity
Sep 20, 2026
Merged

valthon merged 1 commit into
mainfrom
codex/mixed-application-capacity

Conversation

@valthon

@valthon valthon commented Sep 20, 2026

Copy link
Copy Markdown
Owner

Summary

The capacity fixture previously measured only HTTP reads and writes. It now verifies tenant-scoped SSE delivery and transactional durable jobs alongside those requests, with bounded normal-load, stress, drain, and recovery phases. Job payload identities and individual event revisions must match acknowledged writes; malformed, missing, duplicated, foreign, or incomplete work fails the report.

A paired raw-report walkthrough records a real configuration bottleneck: a serial claim batch of two took roughly ten seconds to drain 40 jobs, versus roughly 0.4 seconds with batch 128 on the same shared Debug host. This is evidence about polling/batching, not a production capacity claim. The backlog explicitly defers response caching.

Documentation & examples sync

  • Canonical testing docs, generated skill reference, changelog fragment, and backlog updated.
  • Runnable capacity fixture and negative/live tests updated; raw reports and reproduction commands retained.
  • Public-site generation, validation, build, doctor, static/generated checks, and browser smoke passed.
  • N/A: public application APIs, SDKs, screenshots, and the three example applications.

Verification

  • Mixed-capacity live suite: 12 passed, 16 subtests.
  • Default-load short-duration run and paired 120-request-per-phase experiment passed all request, SSE, job, and isolation checks.
  • Independent source review; malformed SSE and equal-count incorrect job controls added in response.
  • Clean-checkout chapter gate: enabled unit suite plus live capacity/workbench and documentation checks.

Limits remain explicit: local SQLite, one server, closed-loop Python load, synthetic CPU jobs, and warm data. Drain completes before recovery traffic starts. A controlled small-machine saturation report remains open.

Copilot AI lite review requested due to automatic review settings September 20, 2026 00:37
@valthon
valthon added this pull request to stack #466 September 20, 2026 00:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The runner has a critical missing import and unresolved validation gaps.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 High severity

Open (1)
What changed in this PR

Extends the application-capacity fixture with mixed HTTP, tenant-scoped SSE, and durable-job workloads across recovery phases.

Changes:

  • Adds mixed workload validation and isolation checks.
  • Adds tests, fixture updates, diagnostics, and documentation.
  • Updates backlog and changelog.
File Summary
tools/​application_capacity.py Mixed workload runner and validation.
tests/​tools/​test_application_capacity.py Unit and live coverage.
skills/​zigbase-app-genesis/​references/​testing.md Testing guidance updates.
fixtures/​application-capacity/​main.zig Durable job fixture configuration.
docs/​testing.md Capacity testing documentation.
diagnostics/​application-capacity/​batch-sizing/​README.md Batch-sizing methodology.
diagnostics/​application-capacity/​batch-sizing/​batch-2.json Batch-2 raw results.
diagnostics/​application-capacity/​batch-sizing/​batch-128.json Batch-128 raw results.
changelog.d/​mixed-application-capacity.md Changelog entry.
BACKLOG.md Capacity backlog updates.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tools/application_capacity.py
@valthon
valthon force-pushed the codex/mixed-application-capacity branch from 19e1464 to 67f1a96 Compare September 20, 2026 01:23
Copilot AI review requested due to automatic review settings September 20, 2026 01:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Critical SSE duplicate detection and durable-job kind validation issues remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2 High severity

Open (2)
Resolved since last review (1)

Comment thread tools/application_capacity.py Outdated
Comment thread tools/application_capacity.py
Measure tenant reads and writes alongside live SSE delivery and durable
job attempts. Verify individual acknowledged revisions, isolate tenants,
and retain bounded stress and recovery evidence.

Preserve a paired batch-sizing investigation without presenting a shared
Debug host as production capacity. Keep response caching deferred.
@valthon
valthon force-pushed the codex/mixed-application-capacity branch from 67f1a96 to 2a12a5d Compare September 20, 2026 01:56
Copilot AI review requested due to automatic review settings September 20, 2026 01:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved blocking issues were identified.

Review effort: Lite
Findings: None

Resolved since last review (2)

@valthon
valthon merged commit ccb37d3 into main Sep 20, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants