Repository navigation
feat(ui): add classic centered bottom HUD option - #8
Merged
Merged
Conversation
The cherry-picked classic bottom HUD change left the closing brace of the anonymous namespace and the constructor that follows it indented one level, as if they were still inside the namespace. Dedent them back to column zero to match the rest of the file. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the fix for upstream issue sven-n/MuMain#604 from sven-n/MuMain#605 (author: r0naldoom). The responsive bottom HUD anchors its three bands to the window edges and center, so at 16:9 the world shows between them and each band ends on an internal cut of the artwork. This adds an opt-in classic centered bar and keeps the responsive layout as the default.
Changes
88cfeec1with the original author's attribution:[UI] BottomHudClassicconfig key (0by default,1enables the classic bar), loaded at startup.docs/options-window.mdentry.NewUIOptionWindow.cppindented one level too deep. Dedented to match the file.Test plan
ctest -C Release: 215/215 passed, including the new classic-HUD scaling test.BottomHudClassic=1: started and shut down cleanly.🤖 Generated with Claude Code