Repository navigation
feat(repo): repo validate --fail-on-warning - #10
Closed
vchamarthi wants to merge 1 commit into
Closed
vchamarthi wants to merge 1 commit into
vchamarthi wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--fail-on-warningtorepo validate, matchingrepo budget, so a CI job can fail on a validation warning. Default behavior is unchanged.Evidence
experiment_safe.pyrunningcheck.py(builds a one-task toy repo whoseguidance.also_scanmatches nothing, parsesrepo validate <dir> --manifest ...without and with--fail-on-warning) against a copy of the tree at base and at the branchwarning: guidance/also_scan matches no file;--fail-on-warningisdokimi: error: unrecognized arguments, exit 2--fail-on-warningprints the warning and exits 1test_repo_validate_fail_on_warningfails at base under the sandbox (git rev-parse failed: Operation not permitted: '/dev/null', the sandbox denies /dev/null) and was not run green;make ci-localwas not run. The check script stubbed the git tree listing.Blast radius
repo validateonly: one optional flag, default off. Errors still exit 1; output and exit codes without the flag are unchanged. Contract doc usage line and a changelog fragment updated.Overlap
repo budget --out; different subcommand, same files, no conflicting hunk expected.repo fetch --json; different subcommand, same files, no conflicting hunk expected.Created with claude-sonnet-5-5.