Skip to content

feat(repo): repo validate --fail-on-warning - #10

Closed
vchamarthi wants to merge 1 commit into
mainfrom
feat/repo-validate-fail-on-warning
Closed

vchamarthi wants to merge 1 commit into
mainfrom
feat/repo-validate-fail-on-warning

Conversation

@vchamarthi

Copy link
Copy Markdown
Owner

Adds --fail-on-warning to repo validate, matching repo budget, so a CI job can fail on a validation warning. Default behavior is unchanged.

Evidence

  • base: 61e0355 (vchamarthi/dokimi main, synced from intel/dokimi)
  • command: experiment_safe.py running check.py (builds a one-task toy repo whose guidance.also_scan matches nothing, parses repo validate <dir> --manifest ... without and with --fail-on-warning) against a copy of the tree at base and at the branch
  • before: no flag exits 0 with warning: guidance/also_scan matches no file; --fail-on-warning is dokimi: error: unrecognized arguments, exit 2
  • after: no flag still exits 0 with the same warning; --fail-on-warning prints the warning and exits 1
  • not claimed: the new pytest test_repo_validate_fail_on_warning fails at base under the sandbox (git rev-parse failed: Operation not permitted: '/dev/null', the sandbox denies /dev/null) and was not run green; make ci-local was not run. The check script stubbed the git tree listing.

Blast radius

repo validate only: one optional flag, default off. Errors still exit 1; output and exit codes without the flag are unchanged. Contract doc usage line and a changelog fragment updated.

Overlap

Created with claude-sonnet-5-5.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@vchamarthi

Copy link
Copy Markdown
Owner Author

Superseded by intel#149 and intel#150.

@vchamarthi vchamarthi closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant