Preview: validate against libvcs subprocess-trimming#556
Draft
tony wants to merge 1 commit into
Draft
Conversation
why: Validate the downstream impact of libvcs's verbatim-default output capture (vcs-python/libvcs#538) before it ships in a release. what: - Pin libvcs to the branch via [tool.uv.sources]. - Update uv.lock to the branch build.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #556 +/- ##
=======================================
Coverage 83.85% 83.85%
=======================================
Files 30 30
Lines 4354 4354
Branches 873 873
=======================================
Hits 3651 3651
Misses 467 467
Partials 236 236 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
libvcsto its in-developmentsubprocess-trimmingbranch (Return command output verbatim by default libvcs#538) via[tool.uv.sources]to validate the downstream impact of libvcs's verbatim-default subprocess output capture.run()to return output verbatim by default (sogit diffround-trips and applies), with atrim=Trueopt-in for bare-value reads;get_revision()and the scalarrev_parse/rev_listpaths stay bare.Result
vcspull's full suite passes unchanged against the libvcs branch:
No vcspull code changes were needed — it already strips defensively where it compares scalar output, and
get_revision()remains a bare SHA on the libvcs branch.Changes
pyproject.toml: add[tool.uv.sources]pinninglibvcsto the branch.uv.lock: resolveslibvcsto the branch build.Before merge
Drop the
[tool.uv.sources]pin and re-lock once libvcs releases the change; the version constraint (libvcs>=0.43.0,<0.44.0) is unchanged.