Repository navigation
Iterate strings by code point in for loops - #190
Merged
Merged
Conversation
Member
|
I knew this limitation but didn't know that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{{ for c of "..." }}turns a string into items withitem.split(""), which splits by UTF-16 code unit. Characters outside the BMP (emoji, many CJK extension characters) come out as two lone surrogates:renders
a-\ud83d-\ude00-b-(two broken characters) instead ofa-馃榾-b-. Keys fromfor key, c of ...are shifted the same way. AStringobject already iterates by code point because it goes through theSymbol.iteratorbranch, so primitives and objects behave differently today.This uses
Array.from(item), which iterates the way JavaScript's ownfor...ofdoes. ASCII and other BMP strings produce the same items and keys as before.Tests: two cases added to "For tag (string)" in
test/for.test.ts. They fail on main and pass with the change.deno test --allow-read testgives 105 passed, 0 failed (3 ignored), anddeno fmt --checkanddeno lintare clean. I also added an Unreleased entry to CHANGELOG.md; happy to drop it if you prefer to write those yourself.