Repository navigation
Check TypeScript app markup with the TypeScript view compiler - #735
Merged
Merged
Conversation
- `native check` compiles a TypeScript core's views against its contract with the build's own view compiler, and reports unused Model state and Msg kinds from that compile. - TypeScript apps no longer build or read the Zig model-contract artifact; Zig cores keep it. - Update the check docs and skills for both app shapes.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
- Name the real file for `native check` errors in secondary-window views and the files they import. - Cover root, window and imported-file errors, and location-free bundle errors, in tests.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
native checknow compiles a TypeScript core's views (src/app.nativeandsrc/windows/*.native) against the core's contract with the same view compiler the build uses. A view that checks is a view that builds, and there is no artifact to refresh after changing the model. Unused Model fields, helpers and Msg kinds are still reported as warnings (viewUnboundopts out;--strictfails on them).model-contract.zonartifact, so a stale one can no longer produce false errors. Zig-core apps keep the existing model-contract check unchanged.