fix(adapter-posthog): don't start local-evaluation polling from POSTHOG_PERSONAL_API_KEY#432
Open
sarmah-rup wants to merge 1 commit into
Open
Conversation
…OG_PERSONAL_API_KEY
Contributor
|
@sarmah-rup is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The default
postHogAdapterforwardsPOSTHOG_PERSONAL_API_KEYandfeatureFlagsPollingInterval: 10_000into the runtimeposthog-nodeclient. Inposthog-node, a personal API key enables local evaluation, which starts a per-process feature-flag poller.On serverless deployments each warm process runs its own 10s poller, producing large volumes of PostHog feature-flag requests unrelated to real traffic.
Root cause:
POSTHOG_PERSONAL_API_KEYis only needed for provider data discovery (getProviderData), which reads it independently of the runtime client. The two concerns were coupled only in the default singleton.Changes
The default adapter no longer forwards the personal API key or polling interval to the runtime client. Local evaluation remains fully available by constructing the adapter explicitly with
createPostHogAdapterand passingpersonalApiKey/featureFlagsPollingIntervalinpostHogOptions— matching the workaround described in the issue.Testing
Added a regression test asserting the default runtime client is constructed without
personalApiKey/featureFlagsPollingIntervaleven whenPOSTHOG_PERSONAL_API_KEYis set.Note / scope
If you'd prefer an explicit opt-in flag to re-enable local evaluation on the default adapter instead (issue option 2), happy to adjust.
Closes #393