Skip to content

[ci] Increase deploy test concurrency to 8 - #99770

Merged
eps1lon merged 3 commits into
canaryfrom
sebbie/deploy-test-concurrency
Oct 7, 2026
Merged

eps1lon merged 3 commits into
canaryfrom
sebbie/deploy-test-concurrency

Conversation

@eps1lon

@eps1lon eps1lon commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Increases test concurrency for the deploy test jobs to 8 (prev: 2 in the full suite, 1 in new build-and-test jobs).

For deploy tests, the CPU-intensive work that should be as stable as possible (the Next.js build and server) does not happen on the runner. It happens remotely when the deployment is built at Vercel. The runner mostly handles I/O and setup: pushing the deployment, waiting for it to become ready, polling logs, and making requests against it. So the usual reason to cap concurrency (runner CPU contention) barely applies.

Adjusted rate-limits:

Trade-offs to watch:

  • Peak concurrent Vercel deployments per run rises 4× (shards × 2 → shards × 8; 64 → 256 concurrent test files at today's shard counts). If we hit Vercel account deployment-concurrency limits, increase the limits
  • maybe we still need a bit beefier runners if the concurrent setup/tests starve runner CPU

test plan

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Tests Passed

Commit: 695f994

@eps1lon eps1lon changed the title [ci] Increase deploy test concurrency from 2 to 8 [ci] Increase deploy test concurrency to 8 Oct 7, 2026
@eps1lon
eps1lon force-pushed the sebbie/deploy-test-concurrency branch from 45d5f1a to f8a56e4 Compare October 7, 2026 09:45
@eps1lon
eps1lon changed the base branch from canary to sebbie/deploy-timing-instrumentation October 7, 2026 09:46
@eps1lon
eps1lon added this pull request to stack #99785 October 7, 2026 09:46
@eps1lon
eps1lon removed this pull request from stack #99785 October 7, 2026 10:02
@eps1lon
eps1lon force-pushed the sebbie/deploy-test-concurrency branch from f8a56e4 to 44b1586 Compare October 7, 2026 10:03
@eps1lon
eps1lon changed the base branch from sebbie/deploy-timing-instrumentation to canary October 7, 2026 10:03
@eps1lon
eps1lon force-pushed the sebbie/deploy-test-concurrency branch 5 times, most recently from 64a76ed to a400601 Compare October 7, 2026 15:06
eps1lon and others added 3 commits October 7, 2026 20:10
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
RUNNER_DEBUG=1 is set on re-runs with debug logging (matching
@actions/core isDebug()), so vc --debug and its per-API-call status
lines (including 429s) light up without a code change.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@eps1lon
eps1lon requested review from bgw and gnoff October 7, 2026 18:10
@eps1lon
eps1lon marked this pull request as ready for review October 7, 2026 18:10
@eps1lon
eps1lon force-pushed the sebbie/deploy-test-concurrency branch from a400601 to 695f994 Compare October 7, 2026 18:10

@bgw bgw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, seems worth trying.

@eps1lon
eps1lon enabled auto-merge (squash) October 7, 2026 18:42
@eps1lon
eps1lon merged commit 1aec1b2 into canary Oct 7, 2026
119 checks passed
@eps1lon
eps1lon deleted the sebbie/deploy-test-concurrency branch October 7, 2026 18:45
bgw added a commit that referenced this pull request Oct 8, 2026
Reverts #99770

We're seeing a lot of deployment test failures due to rate limits. We
can try bumping the rate limits and trying again, but reverting for
right now to unblock deployment tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants