fix(next): respect basePath for workflow URLs#2732
Conversation
🦋 Changeset detectedLatest commit: 18dd2c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 21 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📊 Benchmark Results
workflow with no steps💻 Local Development
workflow with 1 step💻 Local Development
workflow with 10 sequential steps💻 Local Development
workflow with 25 sequential steps💻 Local Development
workflow with 50 sequential steps💻 Local Development
Promise.all with 10 concurrent steps💻 Local Development
Promise.all with 25 concurrent steps💻 Local Development
Promise.all with 50 concurrent steps💻 Local Development
Promise.race with 10 concurrent steps💻 Local Development
Promise.race with 25 concurrent steps💻 Local Development
Promise.race with 50 concurrent steps💻 Local Development
workflow with 10 sequential data payload steps (10KB)💻 Local Development
workflow with 25 sequential data payload steps (10KB)💻 Local Development
workflow with 50 sequential data payload steps (10KB)💻 Local Development
workflow with 10 concurrent data payload steps (10KB)💻 Local Development
workflow with 25 concurrent data payload steps (10KB)💻 Local Development
workflow with 50 concurrent data payload steps (10KB)💻 Local Development
Stream Benchmarks (includes TTFB metrics)workflow with stream💻 Local Development
stream pipeline with 5 transform steps (1MB)💻 Local Development
10 parallel streams (1MB each)💻 Local Development
fan-out fan-in 10 streams (1MB each)💻 Local Development
SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
❌ Some benchmark jobs failed:
Check the workflow run for details. |
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (571 failed)astro (64 failed):
example (45 failed):
express (76 failed):
fastify (47 failed):
hono (47 failed):
nextjs-turbopack (27 failed):
nextjs-webpack (43 failed):
nitro (53 failed):
nuxt (76 failed):
sveltekit (61 failed):
vite (32 failed):
📋 Other (45 failed)e2e-vercel-prod-tanstack-start (45 failed):
Details by Category❌ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 📋 Other
❌ Some E2E test jobs failed:
Check the workflow run for details. |
Summary
basePaththroughwithWorkflow()asWORKFLOW_BASE_PATHFixes #1864.
This is separate from #2729; it addresses workflow runtime URL construction rather than project root discovery.
Tests
pnpm --filter @workflow/utils buildpnpm --filter @workflow/world-local buildpnpm --filter @workflow/core... buildpnpm --filter @workflow/next... buildpnpm vitest run src/base-path.test.tsfrompackages/utilspnpm vitest run src/runtime/base-url.test.tsfrompackages/corepnpm vitest run src/index.test.tsfrompackages/nextpnpm vitest run src/config.test.ts src/queue.test.tsfrompackages/world-localpnpm changeset status --since=main