[RSDK-14160] Implement support for streaming arm moves#1242
[RSDK-14160] Implement support for streaming arm moves#1242Andrew C. Morrow (acmorrow) wants to merge 7 commits into
Conversation
|
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
|
👋 Thanks for requesting a review from the team! We aim to review PRs within one business day. If this is urgent |
|
Hang back on this one for the moment, there is an update coming due to some small changes in the api repo. |
| """ | ||
| An update reported by the arm as it executes a ``move_through_joint_positions_streamed`` trajectory. | ||
|
|
||
| The type is intentionally empty. The response is a ``oneof`` whose only branch today is an empty |
There was a problem hiding this comment.
Per the comment, note that this type is slightly a lie: the real API Response type for streaming has a oneof message as the only field. But that oneof currently contains only one possible result: a BatchAck, which is itself empty. All of this is in furtherance of not breaking compatibility for old clients if and when additional response data types are added, which is anticipated. For now, it seems reasonable to keep the type silent, since the existence of a reply on the stream is implicitly a batch ack (it can't be anything else on the wire).
OK this is good to go now. |
Depends on viamrobotics/api#874.