Skip to content

[RSDK-14160] Implement support for streaming arm moves#1242

Open
Andrew C. Morrow (acmorrow) wants to merge 7 commits into
viamrobotics:mainfrom
acmorrow:RSDK-14160-streaming-mtjp
Open

[RSDK-14160] Implement support for streaming arm moves#1242
Andrew C. Morrow (acmorrow) wants to merge 7 commits into
viamrobotics:mainfrom
acmorrow:RSDK-14160-streaming-mtjp

Conversation

@acmorrow

Copy link
Copy Markdown
Member

Depends on viamrobotics/api#874.

@github-actions

Copy link
Copy Markdown
Contributor

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base is_moving
board gpio_pin_by_name
button push
genericcomponent do_command
camera get_images
encoder get_position
motor is_moving
sensor get_readings
servo get_position
switch get_position
arm get_end_position
gantry get_lengths
gripper is_moving
movement_sensor get_linear_acceleration
input_controller get_controls
audio get_properties
pose_tracker get_poses
power_sensor get_power
motion get_pose
vision get_properties
mlmodel metadata
genericservice do_command
slam get_point_cloud_map
audio_in get_properties
audio_out get_properties

@viambot

viambot commented Jul 16, 2026

Copy link
Copy Markdown
Member

👋 Thanks for requesting a review from the team!

We aim to review PRs within one business day. If this is urgent
or blocking you, please reach out in #team-sdk and
we'll prioritize it.

@acmorrow

Copy link
Copy Markdown
Member Author

Hang back on this one for the moment, there is an update coming due to some small changes in the api repo.

"""
An update reported by the arm as it executes a ``move_through_joint_positions_streamed`` trajectory.

The type is intentionally empty. The response is a ``oneof`` whose only branch today is an empty

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the comment, note that this type is slightly a lie: the real API Response type for streaming has a oneof message as the only field. But that oneof currently contains only one possible result: a BatchAck, which is itself empty. All of this is in furtherance of not breaking compatibility for old clients if and when additional response data types are added, which is anticipated. For now, it seems reasonable to keep the type silent, since the existence of a reply on the stream is implicitly a batch ack (it can't be anything else on the wire).

@acmorrow

Copy link
Copy Markdown
Member Author

Hang back on this one for the moment, there is an update coming due to some small changes in the api repo.

OK this is good to go now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants