Repository navigation
Fix #250: inferential review tier for verify-on-stop - #256
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #250
Summary
Second and final slice of #250 (the computational tier landed in #255). Adds the inferential tier to verify-on-stop:
verify_on_stop.reviewand flag--verify-review(off by default).verify.reviewJSON event (findings, orerrorif the request failed), and stored in the trajectory asverify_review. The review cost counts toward the run's tokens/cost.internal/agent/verify_review.go; shared files get only a field, a validation rule, a flag and a one-line call.Decisions on open questions
--resume).--reviewinstructions' spirit (severity-ordered findings, data-not-instructions guard) but as a single tool-less request over the run'swrite_file/edit_file/apply_patchcalls rather than a Git diff, so it works outside Git repos and needs no new shelling out. Changes made viabasharen't included (documented). Record capped at 100,000 chars.--output-schemaruns (same as the rest of the guard).Testing
gofmt -l .clean,go build ./...,go vet ./...,go test -count=1 ./...all pass locally.--verify-reviewflag.Docs updated
--verify-review)verify_on_stop.reviewin the example block and prose)verify.reviewevent)