Fix integrated NDI SDK discovery on macOS - #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes discovery and packaging of the installed NDI SDK for integrated macOS builds, including native Apple Silicon support.
Changes
-DndiSdkNDI_SDK_DIR/Library/NDI SDK for AppleNDI SDK for Applex86-64andaarch64integrated targetslib/macOS/libndi.dylibSDK layoutValidation
Validated locally on Apple Silicon with NDI SDK 6.3.2.
Integrated artifact
assembleIntegratedNDIArtifactsnow produces:natives/macos/x86-64/libndi.dylibnatives/macos/x86-64/libndi_licenses.txtnatives/macos/aarch64/libndi.dylibnatives/macos/aarch64/libndi_licenses.txtPublic native artifact
assembleNativeArtifactscontinues to contain only Devolay JNI binaries:natives/macos/x86-64/libdevolay-natives.dylibnatives/macos/aarch64/libdevolay-natives.dylibNo NDI runtime binaries are included in the public native artifact.
Scope
This PR only fixes integrated NDI SDK discovery and packaging on macOS. Maven Central publication behavior remains unchanged.