Skip to content

Fix terminal-mode re-enabling after escape - #256

Merged
Shougo merged 1 commit into
mainfrom
copilot/skkeleton
Sep 9, 2026
Merged

Shougo merged 1 commit into
mainfrom
copilot/skkeleton

Conversation

Copilot AI commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

When skkeleton is used in terminal mode, re-enabling after <Esc> could be routed through the escape state instead of the enable path, leaving skkeleton inactive. PR #252 removed the resulting error but did not restore activation.

  • Enable flow: Allow enable to proceed directly when the current state is escape.
  • Regression coverage: Add a test covering re-enabling from escape state in terminal mode.
if (
  oldState.type !== "escape" &&
  (oldState.type !== "input" || oldState.mode !== "direct") &&
  vimStatus
) {
  return handle(opts, vimStatus);
}

Co-authored-by: Shougo <41495+Shougo@users.noreply.github.com>
@Shougo
Shougo merged commit 40ee4fa into main Sep 9, 2026
2 checks passed
@Shougo
Shougo deleted the copilot/skkeleton branch September 9, 2026 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants