Repository navigation
feat(wizard): review fixes, 6-step flow, a11y, security and deps - #88
Open
Thorfinson wants to merge 4 commits into
Open
Thorfinson wants to merge 4 commits into
Thorfinson wants to merge 4 commits into
Conversation
- fix undo/redo, Python injection and tooltip XSS - make pipeline options work; handle missing values - split step 4 into Projection + Glyphs & Color - add a11y and design tokens - upgrade Angular 21.2.24 and druidjs 0.9 (LLE hidden) - switch tests to Vitest; update CI to Node 24 - ship licence notices; update docs
Member
|
The current state looks good. We still have a problem with "text" columns. We surely would like to keep this information in the tooltips, for example, but not in the projection. Right now, it seems that all columns selected in step 2 are included and the selection in step 4 is ignored (at least in the primary FastMap method).
Attached example dataset: cheese_details @Thorfinson Could you look into this as well during this merge request? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
This PR applies the fixes from a code, UI and accessibility review of
feature/wizard-redesign, plus some cleanup and dependency updates. It also fixes several bugs found along the way. Among them are two security issues and wizard options that previously had no effect.Six steps instead of five: Step 4 is split into Projection and Glyphs & Color, and Review is now Step 6. Saved wizard state in localStorage is migrated automatically (format version 2).
Undo/Redo moved to the title bar, next to Start over. Start over now uses the
restart_alticon and a native confirmation dialog.Accent colour is now
#00737dinstead of#00bcd4for text, focus rings and primary buttons, to meet WCAG contrast. No text is smaller than 11px.druidjs 0.7.3 → 0.9.0
licenses/(LGPL and GPL text plus a notice) and3rdpartylicenses.txt.HIDDEN_PROJECTION_METHODS.Pipeline options that did nothing now take effect:
Processed datasets can therefore differ from before.
Security
workers/pyodide-calls.ts). Unsafe file names are rejected.bypassSecurityTrustHtml. They are now rendered through the template.Fixes
0Truetools/process.py):UX and accessibility
Cleanup and infrastructure
npm auditshows 0 findings..nvmrc); lint, tests and build run before deploy.@defer; initial bundle 1.47 MB → 1.11 MB. Only the filled icon font ships now.projection-preview1,397 → 186 lines (the drawing engine is now separate)processor.py);dataset_common.pymoved totools/.README.md,docs/wizard.md(new developer notes) and theROADMAP.mdsection "Review-Runde".Where to start reviewing
workers/pyodide-calls.ts,canvas/tooltip/: the security fixesservices/preprocessing.service.ts,services/history-diff.ts,services/wizard-storage.ts: undo and storagesrc/assets/preprocessing_processor_config.py: pipeline order and options (processing order is in the file header)shared/constants/step-info.tsand the new step folders: the step splitTest plan
npm run test:ci: 743 passedpython -m pytest tools/tests: 232 passed, each run with default pandas and with pandas-3 behaviourtscfor app, spec and worker;ng lint0 errors;ng build(production) within budgetslicenses/and3rdpartylicenses.txtappear on the deployed siteKnown issues and follow-ups