Treat ToTouch state as an active contact#49
Draft
emmanuelyoussefyoussef wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change treats finger state
0x3(ToTouch) as an active touch contact when settingTipSwitch.Problem
When one finger is already resting on the trackpad and a second finger is added immediately before clicking, the second finger may still be in state
0x3(ToTouch).The current
TipSwitchcondition does not report that state as an active contact. As a result, Windows may see only one active finger when the physical click begins and perform a left-click instead of a two-finger right-click.When both fingers are placed down again together, they usually reach state
0x4(Touch) before the click occurs, which explains why right-clicking works in that case.Changes
The
TipSwitchcondition was updated in:AmtPtpHidFilter/Input.cAmtPtpDeviceUsbUm/InputInterrupt.cState
0x3is now treated as an active touch in addition to the existing state checks.Related issues
Related to #21 and #43.
Testing
This change has been reviewed statically, but I have not compiled, signed, or tested the modified driver on hardware yet. I am opening this as a draft pull request for review and testing.