Skip to content

ci: restore v-analyzer builds with current V - #31751

Merged
medvednikov merged 2 commits into
masterfrom
fix/ci-analyzer-default-branch-20261103
Nov 3, 2026
Merged

medvednikov merged 2 commits into
masterfrom
fix/ci-analyzer-default-branch-20261103

Conversation

@medvednikov

@medvednikov medvednikov commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Problem

The Apps and Modules workflow builds an obsolete vlang/v-analyzer branch. Its explicit --branch=master misses the API/JSON migration already merged into the default main branch.

The current default branch at 7801a67d0583371265c2b50258ee3641c14dfdaf also needs compatibility corrections before the existing debug, static release, and formatting gates pass with current V.

Change

Follow the upstream default branch and apply a small checked-in compatibility patch before building:

  • Give the builder an explicit src target and module search path, with compiler flags before the target.
  • Use current process APIs with literal arguments. The Unix updater inherits standard streams so its build-from-source prompt continues to receive input; Windows retains its existing capture behavior.
  • Require the already-supplied TcpConn instead of constructing an invalid listener-to-connection default.
  • Mark existing Tree-sitter representation casts explicitly unsafe.
  • Correct the one formatting mismatch.

The patch applies to the analyzer checkout only. A reverse applicability check accepts the same fixes once upstream incorporates them; other source drift fails visibly. The original debug, release, and formatting gates stay enabled.

Publishing the companion source fix directly to vlang/v-analyzer was rejected with HTTP 403 (Resource not accessible by integration). Keeping the patch here makes the complete CI repair reviewable and usable without an unpublished dependency. Remove it once upstream contains the corrections.

Validation

Using V 4f6aed937132de4150726a173b597fe51e68c2f3 and analyzer 7801a67d:

  • Reproduced the implicit-src failure, then the 12 production compilation errors after correcting only the path.
  • Actual final debug and statically linked release builds pass; both binaries' --version commands exit 0.
  • macOS arm64 production frontend checking passes. Native macOS compilation/execution was not available locally.
  • Both existing Tree-sitter binding tests pass; formatting checks cover all 335 tracked V files, with the final changed files rechecked.
  • A focused updater control uses a spaced installer path, literal up --nightly arguments, controlled input, and deliberate exit 23. It confirms inherited input/output and exact exit-code propagation; the initially considered redirected-input helper fails this control with EOF. No installer download or installation runs in this check.
  • Workflow YAML and Bash syntax pass. A clean analyzer clone accepts the patch and produces byte-identical copies of all seven validated files; reverse applicability and git diff --check pass.
  • Independent source review found no remaining blocker.

The existing workflow runs these application jobs on master pushes/schedules. Hosted Linux/macOS execution remains the final integration gate.

@medvednikov
medvednikov marked this pull request as ready for review November 3, 2026 01:29
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T07:36:37.513999Z e5d1459 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@medvednikov medvednikov changed the title ci: track the v-analyzer default branch ci: restore v-analyzer builds with current V Nov 3, 2026
@medvednikov
medvednikov merged commit 1787c19 into master Nov 3, 2026
@JalonSolov
JalonSolov deleted the fix/ci-analyzer-default-branch-20261103 branch November 3, 2026 12:20
metif12 pushed a commit to metif12/v that referenced this pull request Nov 4, 2026
* ci: track the v-analyzer default branch

* ci: apply current-V analyzer compatibility fixes before build gates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant