Repository navigation
ci: restore v-analyzer builds with current V - #31751
Merged
Merged
Conversation
medvednikov
marked this pull request as ready for review
November 3, 2026 01:29
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
metif12
pushed a commit
to metif12/v
that referenced
this pull request
Nov 4, 2026
* ci: track the v-analyzer default branch * ci: apply current-V analyzer compatibility fixes before build gates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Apps and Modules workflow builds an obsolete
vlang/v-analyzerbranch. Its explicit--branch=mastermisses the API/JSON migration already merged into the defaultmainbranch.The current default branch at
7801a67d0583371265c2b50258ee3641c14dfdafalso needs compatibility corrections before the existing debug, static release, and formatting gates pass with current V.Change
Follow the upstream default branch and apply a small checked-in compatibility patch before building:
srctarget and module search path, with compiler flags before the target.TcpConninstead of constructing an invalid listener-to-connection default.The patch applies to the analyzer checkout only. A reverse applicability check accepts the same fixes once upstream incorporates them; other source drift fails visibly. The original debug, release, and formatting gates stay enabled.
Publishing the companion source fix directly to
vlang/v-analyzerwas rejected with HTTP 403 (Resource not accessible by integration). Keeping the patch here makes the complete CI repair reviewable and usable without an unpublished dependency. Remove it once upstream contains the corrections.Validation
Using V
4f6aed937132de4150726a173b597fe51e68c2f3and analyzer7801a67d:srcfailure, then the 12 production compilation errors after correcting only the path.--versioncommands exit 0.up --nightlyarguments, controlled input, and deliberate exit 23. It confirms inherited input/output and exact exit-code propagation; the initially considered redirected-input helper fails this control with EOF. No installer download or installation runs in this check.git diff --checkpass.The existing workflow runs these application jobs on master pushes/schedules. Hosted Linux/macOS execution remains the final integration gate.