Repository navigation
feat: add invoice email sending - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
qbo send invoice <id> [--to <email>]for emailing an existing invoice through QuickBooks.--forcefor noninteractive use. Dry runs and refusals do not authenticate or make HTTP requests.sendTo, no redirects and no automatic replay. An empty non-rewindable body prevents Go 1.25/1.26 HTTP/2 from replaying a send after a stream reset.EmailStatusandDeliveryInfobefore sending again. Existing 401/403/404 exit codes are preserved.Verified with
make ci, send tests under Go 1.25.0 and 1.26.0, ten repeated Go 1.25 HTTP/2 regression runs, and real-binary PTY confirmation/refusal smoke tests. The HTTP/2 test reproduced two dispatched requests before the fix and one after it. Fixtures cover HTTP/1.1 and HTTP/2 success, encoding, empty body/headers, failures, redirects, offline dry runs, validation and output.Review gate: approve with nits after an independent correctness sweep and API/copy review. The transport replay finding is fixed and regression-tested. No live QuickBooks email was sent; live gateway behavior remains untested.
The bundled skill and command reference document the no-retry contract, recipient replacement, confirmation, output and inspection after an uncertain send.
Closes #19.