Skip to content

feat: add invoice email sending - #20

Merged
voska merged 2 commits into
mainfrom
feat/invoice-send
Oct 22, 2026
Merged

voska merged 2 commits into
mainfrom
feat/invoice-send

Conversation

@voska

@voska voska commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Adds qbo send invoice <id> [--to <email>] for emailing an existing invoice through QuickBooks.

  • Requires confirmation, or --force for noninteractive use. Dry runs and refusals do not authenticate or make HTTP requests.
  • Discloses third-party email, recipient replacement and existing invoice Cc/Bcc settings.
  • Uses an empty octet-stream POST with encoded sendTo, no redirects and no automatic replay. An empty non-rewindable body prevents Go 1.25/1.26 HTTP/2 from replaying a send after a stream reset.
  • Returns exit 1 for uncertain outcomes, with instructions to inspect EmailStatus and DeliveryInfo before sending again. Existing 401/403/404 exit codes are preserved.
  • Preserves the full JSON response and field selection; human/plain output shows the five delivery fields. Adds schema and README documentation.

Verified with make ci, send tests under Go 1.25.0 and 1.26.0, ten repeated Go 1.25 HTTP/2 regression runs, and real-binary PTY confirmation/refusal smoke tests. The HTTP/2 test reproduced two dispatched requests before the fix and one after it. Fixtures cover HTTP/1.1 and HTTP/2 success, encoding, empty body/headers, failures, redirects, offline dry runs, validation and output.

Review gate: approve with nits after an independent correctness sweep and API/copy review. The transport replay finding is fixed and regression-tested. No live QuickBooks email was sent; live gateway behavior remains untested.

The bundled skill and command reference document the no-retry contract, recipient replacement, confirmation, output and inspection after an uncertain send.

Closes #19.

@voska
voska merged commit e49d5b7 into main Oct 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a send command for invoices (qbo send invoice <id> [--to <email>])

1 participant