fix: support multiple appendTo entries - #1117
Open
pupuking723 wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for vue-devtools-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #746.
This lets
appendToaccept multiple entry matchers:When
appendTois used, the devtools Vite plugin now injects both the devtools overlay and the inspector loader into matching entry modules. The inspector plugin still receivesappendTo: 'manually'for this path, so we don't pass an array tovite-plugin-vue-inspector.Verification:
corepack pnpm exec vitest run packages/vite/__tests__/append-to.test.tscorepack pnpm exec eslint packages/vite/src/vite.ts packages/vite/__tests__/append-to.test.ts docs/guide/vite-plugin.mdcorepack pnpm run type-checkcorepack pnpm run build:vitegit diff --check