Repository navigation
ci: run Docker checks when runtime pins change - #1219
Merged
Merged
Conversation
Merge the Rust version, Node preinstallation, and workspace lock repairs. The Docker workflow change and its 141 passing script tests are unchanged.
loonghao
marked this pull request as ready for review
October 13, 2026 08:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1172.
Changes limited to Docker CI change detection and its regression coverage:
vx.tomlandvx.lockin both the push path filter and the job-level changed-file filter, so updates to thevx hadolintpin run the job that consumes it.No Runtime pins, Rust code, versions, or release settings are changed.
Validation
Reproduced the gap before the workflow changes: 7 failing assertions across 4 new tests.
After the fix: all 4 new tests pass, including the 16-case real
grep -Epath matrix.Full existing Python script suite: 141 tests pass.
Both edited workflows parse as YAML; the actual Docker change-detection script passes
bash -n.Python syntax check and
git diff --checkpass.Repository
just test-scriptsrecipe: 141 tests pass with task-local official just 1.58.0.actionlint 1.7.12 passes for both edited workflows (
-shellcheck= -pyflakes=; those external analyzers were not invoked locally).Validation ran on Linux with Python 3.12. Official vx 0.9.37 and just were installed in a task-local directory. The vx execution wrapper reports offline in this proxy environment, so tests ran through the repository's just recipe directly. Rust and Docker builds were not run locally. Remote checks have reached terminal state for exact head
a6e3359cd64e1f87b0cc195f2e60bfab35047a80:rust_pin_check_tests::test_check_json_reports_declared_and_actualreports configured1.0.0instead of actual1.99.0; the existing Rust installed-version fix is tracked in fix(rust): report the real toolchain version in vx check --json installed #1214 (also fix(rust): report the real toolchain as installed, not the declared pin #1213). 4,310 passed, 1 failed, 130 skipped; one other test passed on retry.cross_tool::test_env_propagation,cross_tool::test_multiple_tools_version_sequence,cross_tool::test_package_manager_switch, andnode::test_node_evaltimed out at 300 seconds on each of three attempts. This matches the Node-preinstallation issue already addressed by fix: harden 7z path-traversal test and preinstall Node on Linux CI #1216. 4,282 passed, 4 failed, 128 skipped; four other tests passed on retry.Those independent fixes have now merged. Head
e9e37d8afa6177582e16bc1258ce6d0e62d5db1eincorporates verified main747785221dfbe3389dabffcbdf4209d85ab23d0c, including #1214, #1216, #1221, and #1222. The diff against main remains the same three Docker-filter/regression files; no runtime pin or dependency change was added. The 141-test script suite passes again on the cloud Linux machine. Exact-head CI has completed: all 50 checks are terminal (33 successful, 17 skipped), including Docker, Script Tests, quality, and CI Success. Linux Full passes 4,288/4,288, macOS Full 4,291/4,291, and Windows Full 4,312/4,312. Windows' existing imagemagick alias test passes on attempt 2, the same caveat seen on base main; this change does not address that test. The older failed run remains visible.