Skip to content

ci: run Docker checks when runtime pins change - #1219

Merged
loonghao merged 2 commits into
mainfrom
fix/docker-pin-filter-1172-20261012
Oct 13, 2026
Merged

loonghao merged 2 commits into
mainfrom
fix/docker-pin-filter-1172-20261012

Conversation

@loonghao

@loonghao loonghao commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Closes #1172.

Changes limited to Docker CI change detection and its regression coverage:

  • Include root vx.toml and vx.lock in both the push path filter and the job-level changed-file filter, so updates to the vx hadolint pin run the job that consumes it.
  • Keep pull requests unconditionally eligible for the Docker Success gate.
  • Add script regression tests using the actual workflow regex, covering both pin files, existing Docker inputs, mixed changes, and unrelated or similarly named paths.
  • Run the existing Script Tests workflow when the Docker workflow changes, so its regression tests cannot be skipped by a workflow-only edit.

No Runtime pins, Rust code, versions, or release settings are changed.

Validation

  • Reproduced the gap before the workflow changes: 7 failing assertions across 4 new tests.

  • After the fix: all 4 new tests pass, including the 16-case real grep -E path matrix.

  • Full existing Python script suite: 141 tests pass.

  • Both edited workflows parse as YAML; the actual Docker change-detection script passes bash -n.

  • Python syntax check and git diff --check pass.

  • Repository just test-scripts recipe: 141 tests pass with task-local official just 1.58.0.

  • actionlint 1.7.12 passes for both edited workflows (-shellcheck= -pyflakes=; those external analyzers were not invoked locally).

Validation ran on Linux with Python 3.12. Official vx 0.9.37 and just were installed in a task-local directory. The vx execution wrapper reports offline in this proxy environment, so tests ran through the repository's just recipe directly. Rust and Docker builds were not run locally. Remote checks have reached terminal state for exact head a6e3359cd64e1f87b0cc195f2e60bfab35047a80:

Those independent fixes have now merged. Head e9e37d8afa6177582e16bc1258ce6d0e62d5db1e incorporates verified main 747785221dfbe3389dabffcbdf4209d85ab23d0c, including #1214, #1216, #1221, and #1222. The diff against main remains the same three Docker-filter/regression files; no runtime pin or dependency change was added. The 141-test script suite passes again on the cloud Linux machine. Exact-head CI has completed: all 50 checks are terminal (33 successful, 17 skipped), including Docker, Script Tests, quality, and CI Success. Linux Full passes 4,288/4,288, macOS Full 4,291/4,291, and Windows Full 4,312/4,312. Windows' existing imagemagick alias test passes on attempt 2, the same caveat seen on base main; this change does not address that test. The older failed run remains visible.

Merge the Rust version, Node preinstallation, and workspace lock repairs.
The Docker workflow change and its 141 passing script tests are unchanged.
@loonghao
loonghao marked this pull request as ready for review October 13, 2026 08:40
@loonghao
loonghao merged commit 6bfdf2a into main Oct 13, 2026
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: vx hadolint is invoked but its pin is never verified (Validate Dockerfile syntax is skipped by path filter)

1 participant