Repository navigation
ci: discover the installed MSVC instance for examples - #1220
Merged
Merged
Conversation
Check each native exit code immediately, preserve output in the build log, and exercise install/rebuild/module failures with a real native cmd shim. Merge the verified main fixes without altering dependencies.
Fetch the reviewed upstream revision without editing its manifests or lock. Use the existing VX Bun pin and frozen install, source-build better-sqlite3, and validate a real SQLite query with Node. Preserve native failure checks.
loonghao
marked this pull request as ready for review
October 13, 2026 11:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repair the Windows example toolchain contract and validate the complete example chain without changing VX tool pins or the external project's dependencies.
vswhereinstead of assuming its edition or path. VS17 is the common supported range of the current VX Provider and node-pty's node-gyp; this does not imply the runner lacks VS18.6744099b279b991c17e31c243f0920477bd31cb6and use the existing VX Bun pin withbun install --frozen-lockfile. Do not rewrite workspace protocols, resolutions, manifests, or lockfiles.better-sqlite3for VX's Node ABI, serialize npm lifecycle scripts through Bun's shared dependency links, and validate an actual in-memory database query.Exact-head validation
Head:
55f5f16fe95aff8ea6dc352634de42f23eb26893test_where_alias_imagemagickpassed on its second attempt; this flaky-test caveat is retained rather than treated as a first-attempt pass.BeforeAllerrors, assertion failures, no tests, and all-skipped tests return 1. Native install/rebuild/query failures independently preserve exit codes 31/32/33 and stop subsequent commands.git diff --checkpasses. No local PowerShell or Rust build is claimed. PowerShell and native Windows acceptance come from the jobs above.The AionUi acceptance is a native-module toolchain smoke test using Node, not a full Electron packaging test.
Diagnosis and regression evidence
EBUSY; exit code 1 was correctly preserved. The final foreground lifecycle option serializes those builds, as confirmed by the successful real logs above.References