Repository navigation
ci: gate installer extended formats on native platforms - #1223
Merged
Merged
Conversation
loonghao
marked this pull request as ready for review
October 13, 2026 09:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sevenz_sfx_testsintegration target withextended-formatsenabled.CI Successwhenever Rust/CI changes select tests. A skipped, cancelled, failed, or empty result cannot satisfy the selected gate.Why
The default workspace test suite does not enable the installer’s optional 7z code. The full-coverage run https://github.com/vx-org/vx/actions/runs/38361693365 timed out in network-dependent CLI tests before reaching
sevenz_sfx_tests; it did not verify the installer regressions from #1216. The new lane isolates native extraction and path-safety checks from those CLI tests.The existing full-workspace, all-features coverage command, timeout, and gate remain unchanged. No production code or dependencies change.
Validation
git diff --checkpasses.0e5708955b6a9b6c43f89bea198ad00935eca2b8: CI run 38369084693 andCI Successcompleted successfully.force_full_cijob and was not run by this PR event; the focused installer results are not a coverage claim.Post-merge verification
327d8068e8a830f540266077f0ffc667b7cf6db4; main CI run 38384652247 and its aggregateCI Successcompleted successfully.test_where_alias_imagemagick(alias exit-status equality failed on its first attempt, passed on the second). This is separate from the zero-retry installer lane and has been surfaced for follow-up.