Skip to content

ci: gate installer extended formats on native platforms - #1223

Merged
loonghao merged 1 commit into
mainfrom
ci/installer-extended-formats
Oct 13, 2026
Merged

loonghao merged 1 commit into
mainfrom
ci/installer-extended-formats

Conversation

@loonghao

@loonghao loonghao commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Add a focused Linux, Windows, and macOS lane that runs the real sevenz_sfx_tests integration target with extended-formats enabled.
  • Require a successful native matrix in CI Success whenever Rust/CI changes select tests. A skipped, cancelled, failed, or empty result cannot satisfy the selected gate.
  • Fail on zero tests and disable retries for these deterministic archive safety regressions.
  • Add seven executable workflow contract tests to change detection, including failure/cancellation/skip cases for the actual success-gate shell.

Why

The default workspace test suite does not enable the installer’s optional 7z code. The full-coverage run https://github.com/vx-org/vx/actions/runs/38361693365 timed out in network-dependent CLI tests before reaching sevenz_sfx_tests; it did not verify the installer regressions from #1216. The new lane isolates native extraction and path-safety checks from those CLI tests.

The existing full-workspace, all-features coverage command, timeout, and gate remain unchanged. No production code or dependencies change.

Validation

  • Local: 144 Python script tests passed, including all seven new contract tests.
  • Local: workflow YAML parses and git diff --check passes.
  • Exact head 0e5708955b6a9b6c43f89bea198ad00935eca2b8: CI run 38369084693 and CI Success completed successfully.
  • Native installer regression tests: Linux 5/5, Windows 4/4, macOS 5/5; zero skipped tests and retries disabled. Unix lanes also exercised existing-symlink rejection.
  • Full workspace tests: Linux 4288 passed / 128 skipped; Windows 4312 passed / 130 skipped; macOS 4291 passed / 128 skipped. All three reported zero flaky tests.
  • All seven associated workflows completed successfully. An independent exact-head review found no blockers.
  • Full coverage remains an opt-in force_full_ci job and was not run by this PR event; the focused installer results are not a coverage claim.
  • No local Rust test pass is claimed; the reset cloud environment has no matching VX/Rust toolchain. The real extractor tests were verified on native CI runners.

Post-merge verification

  • Merged as 327d8068e8a830f540266077f0ffc667b7cf6db4; main CI run 38384652247 and its aggregate CI Success completed successfully.
  • The merged main commit ran the native installer regressions again: Linux 5/5, Windows 4/4, macOS 5/5, with zero skipped tests and retries disabled.
  • Full workspace: Linux 4289 passed / 128 skipped; macOS 4292 passed / 128 skipped; Windows 4313 passed / 130 skipped. Linux/macOS reported zero flakes. Windows reported one existing-suite flake in test_where_alias_imagemagick (alias exit-status equality failed on its first attempt, passed on the second). This is separate from the zero-retry installer lane and has been surfaced for follow-up.
  • The separate Release Please run remains blocked by the existing GitHub Actions permission to create/approve PRs; no repository permissions were changed.

@loonghao
loonghao marked this pull request as ready for review October 13, 2026 09:33
@loonghao
loonghao merged commit 327d806 into main Oct 13, 2026
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant