Repository navigation
Conversation
loonghao
marked this pull request as ready for review
November 17, 2026 10:39
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The current audit job reports success even when its log says
8 vulnerabilities foundand8 denied warnings found. It also attempts a lock regeneration that fails because thezip ^8.1compatible releases are yanked. The leading-in the just recipe and|| truein the scheduled workflow hide both errors.Concrete existing-head audit evidence.
Verification
Scope and expected result
This is a truthful reporting fix, not a dependency remediation. With the current dependencies the real audit is expected to fail, and CI must reflect that. No Cargo.toml/Cargo.lock change, advisory exclusion, warning relaxation, permission, credential, branch-protection or release-setting change.
The compatible dependency patches remain separately in #1227. Remaining dependencies and the existing advisory inline-test warning are separate work. This PR remains Draft; no merge or release is included.
Final-head verification
Final head
a245ee621e25f768b0ce116a4d87e487e86364beincludes the independent-review test hardening.|| :and a disabled scheduled audit step) now both fail the contract test.vx just security-audit-ci→vx cargo audit --deny warnings. It scanned 573 committed dependencies, reported 13 vulnerabilities and 9 denied warnings, and failed with exit code 1, including the failing recipe and GitHub step. There is nogenerate-lockfileinvocation in this log.security-audit=failureand exited 1. This verifies end-to-end failure propagation; it is not an infrastructure error or a clean security audit.vx::integration_tests tool_specific_tests::test_go_tool_helpas LEAK (1 leaky passing test); this is not a claim of warning-free tests.no operations to perform), formatting, clippy and docs. Its pre-existing inline-test checker still fails under|| true; that advisory result remains explicitly out of scope and must not be called a fully clean quality gate.Strict audit of merged main — 2026-10-17 08:03 UTC
The compatible lock patches in #1227 are now merged as
0388b75a24f28b376c5372c95a4d064ffdd581df. A separate read-only audit of that exact committed lock reports 11 vulnerabilities and 7 denied warnings, with exit code 1.7fb9497f8594b389e5fce5ef9b92db08432996895b2e0c5a0167a69ed445c428, verified before execution.bffb70410116a0e4dc754fcbe32559bc009c8e40, SHA256dff420534c64eba856804ad49036002e8215bc87c1202ca9391206b3cfeeca2b. The blob matches merged main and its bytes were unchanged after both JSON and terminal audits.cargo-audit audit --deny warnings --file Cargo.lock --db advisory-db --json; terminal confirmation used the same database with--no-fetch. No ignore, target filtering, lock regeneration or dependency update was used.64f92cdc64401fab47baa10e2e11fe382aa57155, 1334 advisories.Dependency remediation remains outstanding. The audit-gate fix in #1228 remains Draft and blocked by its failed required CI Success check; no protection or permission changes, bypass, or merge of #1228 was performed.