Skip to content

fix: reject zero owner IDs #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vycdev merged 2 commits into from
Sep 16, 2026
Merged

fix: reject zero owner IDs #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c02bdc
fix: reject zero owner IDs
vycdev2 Sep 15, 2026
1eb5200
Merge remote-tracking branch 'origin/develop' into review-20260916-205
vycdev Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Modules/AdministratorModule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,9 @@ internal static int CalculateLogSkipCount(int page, int pageSize)
internal static bool TryParseOwnerId(string? value, out ulong ownerId)
{
ownerId = 0;
return !string.IsNullOrWhiteSpace(value) && ulong.TryParse(value, out ownerId);
return !string.IsNullOrWhiteSpace(value) &&
ulong.TryParse(value, out ownerId) &&
ownerId > 0;
}

internal static IReadOnlyList<string> BuildLogMessages(IEnumerable<string> lines)
Expand Down
1 change: 1 addition & 0 deletions Morpheus.Tests/AdministratorModuleTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ public class AdministratorModuleTests
[InlineData(null)]
[InlineData("")]
[InlineData(" ")]
[InlineData("0")]
[InlineData("not-a-user-id")]
public void TryParseOwnerId_RejectsMissingOrInvalidValues(string? value)
{
Expand Down