Skip to content

Recalculate star column widths when a column is hidden - #473

Open
AsafMah wants to merge 1 commit into
w-ahmad:mainfrom
AsafMah:fix/star-width-on-column-hide
Open

AsafMah wants to merge 1 commit into
w-ahmad:mainfrom
AsafMah:fix/star-width-on-column-hide

Conversation

@AsafMah

@AsafMah AsafMah commented Oct 28, 2026 •

Copy link
Copy Markdown

Description

Hiding a column (setting its Visibility to Collapsed) didn't recalculate star column widths. Star columns kept their old width and left an empty gap where the hidden column had been. Showing a column already recalculated them, through AddHeaders → CalculateHeaderWidths. This makes the hide path do the same, in TableViewHeaderRow.OnColumnPropertyChanged.

Repro: a Width="*" column plus a few fixed-width columns; set one fixed column's Visibility to Collapsed. Before: a gap. After: the star column takes the space.

Related Issue

None opened.

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 📝 Documentation update
  • ♻️ Refactor
  • 🧪 Test
  • 🔧 Chore / maintenance

Checklist

  • This PR is not from my main branch
  • Tested with WinUI target (in an app: hiding a column from a menu; the star Name column now fills the space)
  • Tested with Uno Platform target (not tested)
  • Unit / integration tests added or updated (none added; the existing suite passes locally, except one test that also fails on main here, see Add public Sort, Group and Ungroup methods to TableViewColumn #471)
  • Documentation updated to reflect changes (not needed)
  • Code follows the project's coding conventions

🤖 Generated with Claude Code

Showing a column recalculated them (AddHeaders), hiding one didn't, so star
columns kept their old width and left a gap where the hidden column was.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant