Skip to content

Rebuild groups without rendering an empty table in between #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AsafMah wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

Rebuild groups without rendering an empty table in between #474

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/TableView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,15 +105,16 @@ private void OnCollectionViewPropertyChanging(object? sender, PropertyChangingEv
/// <summary>
/// Handles the PropertyChanged event of the CollectionView.
/// </summary>
private async void OnCollectionViewPropertyChanged(object? sender, PropertyChangedEventArgs e)
private void OnCollectionViewPropertyChanged(object? sender, PropertyChangedEventArgs e)
{
if (e.PropertyName == nameof(CollectionView.CollectionGroups))
{
_collectionView.CollectionGroups?.VectorChanged += OnCollectionViewGroupDescriptionsChanged;

// Detach and reattach so the ListView rebuilds its groups. Both in one go: yielding between them let a
// frame render the table empty, a visible flicker on every grouping change.
_shouldThrowBaseProeprtyChangedException = false;
base.ItemsSource = null;
await Task.Yield();
base.ItemsSource = _collectionView;
_shouldThrowBaseProeprtyChangedException = true;
}
Expand Down