Repository navigation
AFDocs fixes: preserve file-tree examples and audit diagnostics - #972
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This PR was generated with Warp. Comment |
There was a problem hiding this comment.
Overview
Reviewed all five changed files at cfc410ba, including correctness, standards, complexity, naming, comments, test value/coverage, security, and the PR description; no change-specific correctness or security defects found. The changes preserve FileTree content and original diagnostics, with a conservative partial-scan rule consistent with the inspected afdocs@0.22.2 fields.
Concerns
- Important — CI blocker, not a code finding: Agent docs review failed before reviewing anything because ID-token authentication returned 401 Unauthorized. CI is red and the PR is blocked; the workflow/authentication owner needs to repair access and rerun the check before merge.
- Suggestion: The new audit regression tests are not invoked by CI; see the inline comment.
Verification
- Independently reproduced both original bugs against
origin/main; the PR fixes them. Markdown-AST checks retain all 32 entries across four FileTrees on two built pages, while browser search-exclusion attributes and explicitly excluded ancestors remain intact. - Focused suites: 20/20 passed. Ordered checks passed:
typecheck→test:heading-vars(5/5) →build→test:heading-tocs(3,446 entries / 409 files) →test:homepage-json-ld;git diff --checkpassed and tracked source remains unchanged. - Limits: no new live crawl, deployed-score verification, or browser/UI test; browser HTML is unchanged. Trunk lint/format could not be run because Trunk is unavailable; dependency engine/patch-version and non-fatal build warnings remain noted in the PR.
Verdict
Checks: build pass, tests pass, CI red, visual proof n/a.
Found: 0 critical, 1 important (CI infrastructure), 1 suggestion, 0 nits. No source changes, approval, or merge performed.
Responding as Docs Factory (V2): Open session · View in factory
Co-Authored-By: Oz <oz-agent@warp.dev>
|
@rachaelrenk, your GitHub account is not connected to Warp. Connect your GitHub account. |


Summary
The audit found a genuinely missing file-tree example; preserve it in Markdown and retain page diagnostics so interrupted scans cannot establish baselines.
Related issues
Requested follow-up · Audit evidence and reports.
Validation
All 20 targeted tests pass (three new regressions failed before the fix); captured production HTML and built Markdown retain all three rules examples.
Passed in order:
npm run typecheck,npm run test:heading-vars,npm run build,npm run test:heading-tocs,npm run test:homepage-json-ld; internal links: 4,624 checked, zero broken;git diff --checkpassed.npm run lintandnpm run fmtcould not run: Trunk is missing; install warned about Babel's Node requirement and the existing patch-version mismatch; build emitted seven typecheck hints, large-chunk, empty-i18n, and/404conflict warnings.Follow-ups
Complete sampled audit: native v0.6.0, 90/100 (A-), unchanged versus the last complete baseline; two allowlisted failures, one parity warning (real file-tree loss plus bracket-escaping noise); no interaction effects or post-deployment score claimed.
The morning's failed URL and warning pages were discarded and cannot be reconstructed; this different sample does not resolve those observations, and the original partial log remains excluded from comparisons.
Documentation risk
Risk: low
Rationale: Preserves existing examples and formatting in Markdown plus internal audit diagnostics; no product claims or developer-facing commands change.
Docs override: none
Unverified claims
None; no public prose or product behavior claims changed.
Co-Authored-By: Oz oz-agent@warp.dev