Skip to content

AFDocs fixes: preserve file-tree examples and audit diagnostics - #972

Merged
rachaelrenk merged 2 commits into
mainfrom
afdocs-fixes
Oct 30, 2026
Merged

rachaelrenk merged 2 commits into
mainfrom
afdocs-fixes

Conversation

@warp-agent-staging

Copy link
Copy Markdown
Contributor

Summary

The audit found a genuinely missing file-tree example; preserve it in Markdown and retain page diagnostics so interrupted scans cannot establish baselines.

Related issues

Requested follow-up · Audit evidence and reports.

Validation

All 20 targeted tests pass (three new regressions failed before the fix); captured production HTML and built Markdown retain all three rules examples.
Passed in order: npm run typecheck, npm run test:heading-vars, npm run build, npm run test:heading-tocs, npm run test:homepage-json-ld; internal links: 4,624 checked, zero broken; git diff --check passed.
npm run lint and npm run fmt could not run: Trunk is missing; install warned about Babel's Node requirement and the existing patch-version mismatch; build emitted seven typecheck hints, large-chunk, empty-i18n, and /404 conflict warnings.

Follow-ups

Complete sampled audit: native v0.6.0, 90/100 (A-), unchanged versus the last complete baseline; two allowlisted failures, one parity warning (real file-tree loss plus bracket-escaping noise); no interaction effects or post-deployment score claimed.
The morning's failed URL and warning pages were discarded and cannot be reconstructed; this different sample does not resolve those observations, and the original partial log remains excluded from comparisons.

Documentation risk

Risk: low
Rationale: Preserves existing examples and formatting in Markdown plus internal audit diagnostics; no product claims or developer-facing commands change.
Docs override: none

Unverified claims

None; no public prose or product behavior claims changed.

Co-Authored-By: Oz oz-agent@warp.dev

@warp-agent-staging warp-agent-staging Bot added warpy-factory Opened by the Warp factory agents factory:docs-factory Label associated to the "docs-factory" factory labels Oct 30, 2026
@cla-bot cla-bot Bot added the cla-signed label Oct 30, 2026
@vercel

vercel Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 30, 2026 8:31pm UTC

Request Review

@warp-agent-staging

Copy link
Copy Markdown
Contributor Author

This PR was generated with Warp.

Comment @warp-staging-factory on this PR to send it follow-up work.

@warp-agent-staging warp-agent-staging Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

Reviewed all five changed files at cfc410ba, including correctness, standards, complexity, naming, comments, test value/coverage, security, and the PR description; no change-specific correctness or security defects found. The changes preserve FileTree content and original diagnostics, with a conservative partial-scan rule consistent with the inspected afdocs@0.22.2 fields.

Concerns

  • Important — CI blocker, not a code finding: Agent docs review failed before reviewing anything because ID-token authentication returned 401 Unauthorized. CI is red and the PR is blocked; the workflow/authentication owner needs to repair access and rerun the check before merge.
  • Suggestion: The new audit regression tests are not invoked by CI; see the inline comment.

Verification

  • Independently reproduced both original bugs against origin/main; the PR fixes them. Markdown-AST checks retain all 32 entries across four FileTrees on two built pages, while browser search-exclusion attributes and explicitly excluded ancestors remain intact.
  • Focused suites: 20/20 passed. Ordered checks passed: typecheck → test:heading-vars (5/5) → build → test:heading-tocs (3,446 entries / 409 files) → test:homepage-json-ld; git diff --check passed and tracked source remains unchanged.
  • Limits: no new live crawl, deployed-score verification, or browser/UI test; browser HTML is unchanged. Trunk lint/format could not be run because Trunk is unavailable; dependency engine/patch-version and non-fatal build warnings remain noted in the PR.

Verdict

Checks: build pass, tests pass, CI red, visual proof n/a.
Found: 0 critical, 1 important (CI infrastructure), 1 suggestion, 0 nits. No source changes, approval, or merge performed.

Responding as Docs Factory (V2): Open session · View in factory

Co-Authored-By: Oz <oz-agent@warp.dev>
@warp-agent-staging

Copy link
Copy Markdown
Contributor Author

@rachaelrenk, your GitHub account is not connected to Warp. Connect your GitHub account.

@rachaelrenk
rachaelrenk merged commit 9bf93e4 into main Oct 30, 2026
11 of 12 checks passed
@rachaelrenk
rachaelrenk deleted the afdocs-fixes branch October 30, 2026 20:41

This branch was successfully deployed

1 active deployment
Preview — 2e7d6b9e Deployed Oct 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed factory:docs-factory Label associated to the "docs-factory" factory warpy-factory Opened by the Warp factory agents

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant