Repository navigation
Support primary agent issue classification and agent:priority-high triage - #500
Conversation
Update automated issue triage to support feature and security classifications alongside priority:high tagging for regressions, panics, crashes, and security vulnerabilities. Co-Authored-By: Warp <agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR updates the issue triage workflow and triage skill guidance to classify issues into primary labels and apply priority:high for urgent regressions, crashes, data loss, and security reports. It also extends retriage label handling and adds unit coverage for feature, security, and priority:high labels.
Concerns
- No blocking correctness, security, comment-quality, test-quality, or spec-alignment concerns were found in the annotated diff.
- No approved or repository spec context was supplied, so there was no material spec drift to flag.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
vkodithala
left a comment
There was a problem hiding this comment.
Mostly LG, two small changes we should consider.
| - the user's hypotheses, proposed fixes, or root-cause claims | ||
| - the missing details that block confident triage | ||
| 2. Classify whether the issue is primarily a bug report, enhancement request, documentation issue, or needs more information. As part of classification, detect reports that cannot be resolved through OSS contributions — billing inquiries, plan changes, refund requests, subscription or account management, pricing questions, and payment issues. These belong with the Warp support team, not OSS contributors: request the `warp:needs-support` label, set `close_issue` to `true`, and put a brief reporter-facing message in `statements` directing the user to contact Warp support (for example, "For plan changes or refund requests, please contact Warp support at support@warp.dev"). For these reports, do not produce follow-up questions, root-cause analysis, or duplicate detection — the support escalation is the triage outcome. Do not set `close_issue` for issues that can be addressed via OSS contributions; leave it `false` or omitted. | ||
| 2. Classify every issue into at least one primary type (`bug`, `feature`, `security`, `documentation`). As part of classification, detect reports that cannot be resolved through OSS contributions — billing inquiries, plan changes, refund requests, subscription or account management, pricing questions, and payment issues. These belong with the Warp support team, not OSS contributors: request the `warp:needs-support` label, set `close_issue` to `true`, and put a brief reporter-facing message in `statements` directing the user to contact Warp support (for example, "For plan changes or refund requests, please contact Warp support at support@warp.dev"). For these reports, do not produce follow-up questions, root-cause analysis, or duplicate detection — the support escalation is the triage outcome. Do not set `close_issue` for issues that can be addressed via OSS contributions; leave it `false` or omitted. |
There was a problem hiding this comment.
Yeah again, related to my feedback on the downstream PR here; I think the right thing to do is add provenance directly to these labels.
| triage. Be direct and precise; do not re-emit the triage | ||
| shape's fields when you choose this mode. | ||
| - Prefer labels from the `triage_config` object in `{_REPOSITORY_TRIAGE_CONTEXT_ATTACHMENT}`. | ||
| - Classify every issue into at least one primary type (`bug`, `feature`, `security`, `documentation`). Tag regressions ("broke in recent version", "worked before"), crashes/panics/data loss, or security vulnerabilities with `priority:high`. |
There was a problem hiding this comment.
nit: Is there a way to parametrize primary labels? Don't we keep this as a var somewhere?
Update automated triage to emit agent:bug, agent:feature, agent:security, and agent:documentation, and parametrize primary issue types in the prompt builder. Co-Authored-By: Warp <agent@warp.dev>
Update prompt, config, skill, and test cases to use agent:priority-high. Co-Authored-By: Warp <agent@warp.dev>
…igh (#15868) ## Description Updates the repository's issue triage configuration and companion triage skill to encode provenance directly into agent-assigned classifications (`agent:bug`, `agent:feature`, `agent:security`, `agent:documentation`) and support urgent issue prioritization with `agent:priority-high`. ### What changed - `.github/issue-triage/config.json`: Added `agent:bug` (`#8ff8fd`), `agent:feature` (`#f47f64`), `agent:security` (`#a0ce9f`), `agent:documentation` (`#5f966f`), and `agent:priority-high` (`#b60205`) label definitions. - `.agents/skills/triage-issue-local/SKILL.md`: Documented the primary agent types and `agent:priority-high` in the label taxonomy section and updated heuristics to direct the triage agent to classify issues into primary agent types (exempting billing/appeals reports that route to support via `warp:needs-support`) and explicitly bias toward applying `agent:priority-high` to regressions ("broke in recent version", "worked before"), crashes/panics, data loss, and security vulnerabilities. ### Stack & Connections This PR is part of a 3-repo stack to pause non-KTLO triage noise ahead of Factory GA: - **`warpdotdev/warp`** (this PR): Defines the agent label taxonomy and repository-local skill guidance. - **`warpdotdev/oz-for-oss`** (PR warpdotdev/oz-for-oss#500): Updates the automated triage workflow to classify issues into primary agent types, parametrize primary types in prompt construction, and preserve `agent:priority-high` during retriage. - **`warpdotdev/ossie`** (PR warpdotdev/ossie#64): Updates issue triage Slack alerts to suppress individual messages/pings for non-prioritized issues, reserving individual Slack alerts for `agent:security` and `agent:priority-high` issues. Co-Authored-By: Warp <agent@warp.dev> --------- Co-authored-by: Warp <agent@warp.dev>
Description
Updates the automated issue triage workflow in
oz-for-ossto support classifying open-source issues into primary categories with provenance (agent:bug,agent:feature,agent:security,agent:documentation) and tagging urgent issues (regressions, crashes/panics/data loss, security reports) withagent:priority-high.What changed
core/workflows/triage_new_issues.py:PRIMARY_ISSUE_TYPES = ("agent:bug", "agent:feature", "agent:security", "agent:documentation")and parametrized primary issue types inbuild_triage_prompt.PRIMARY_ISSUE_TYPEStoPRIMARY_TRIAGE_LABELSand definedPRIORITY_LABELS = {"agent:priority-high", "priority:high"}.apply_triage_resultto replace prior primary triage labels on retriage viashould_replace_triage_labeland preserveagent:priority-highinmanaged_labels..github/issue-triage/config.json:agent:bug(#8ff8fd),agent:feature(#f47f64),agent:security(#a0ce9f),agent:documentation(#5f966f), andagent:priority-high(#b60205)..agents/skills/triage-issue/SKILL.md:agent:priority-high.tests/test_triage.py:agent:feature,agent:security, andagent:priority-high.Manual Operational Steps Required for Rollout
warpdotdev/warpto classify them intoagent:bug,agent:feature,agent:security, oragent:documentation, and tag high-priority regressions/crashes withagent:priority-high.warprepo: Ensure theagent:bug(#8ff8fd),agent:feature(#f47f64),agent:security(#a0ce9f),agent:documentation(#5f966f), andagent:priority-high(#b60205) labels exist inwarpdotdev/warp(addressed via Update triage taxonomy with agent: primary types and agent:priority-high warp#15868).Stack & Connections
This PR is part of a 3-repo stack to pause non-KTLO triage noise ahead of Factory GA:
warpdotdev/warp(PR Update triage taxonomy with agent: primary types and agent:priority-high warp#15868): Configures repository-level label taxonomy and local companion skills.warpdotdev/oz-for-oss(this PR): Directs automated triage to output primary type classifications andagent:priority-high.warpdotdev/ossie(PR https://github.com/warpdotdev/ossie/pull/64): Updates Slack triage alerts to suppress individual messages/pings for non-prioritized issues, reserving individual Slack alerts foragent:securityandagent:priority-highissues.Co-Authored-By: Warp agent@warp.dev