Repository navigation
Add Warp Factory definition files - #503
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
<!-- warp-factory-provisioning-v2 commit="eyJ0YXJnZXQiOnsic2NvcGUiOnsiZmFjdG9yeV91aWQiOiJTWndMWFd0M2kyTlEzREM2cktqYVRiIiwiZm9yZ2UiOiJnaXRodWIiLCJyZXBvc2l0b3J5Ijp7Ik93bmVyIjoid2FycGRvdGRldiIsIk5hbWUiOiJvei1mb3Itb3NzIn0sInByb2R1Y3Rpb25fYnJhbmNoIjoibWFpbiJ9LCJkaXJlY3RvcnlfcGF0aCI6ImxpbmtpbmctdGVzdCJ9LCJmaWxlcyI6WyJsaW5raW5nLXRlc3QvYWdlbnRzL0xpbmtpbmcgVGVzdCBGb3JlbWFuIEFnZW50L2FnZW50Lm1kIiwibGlua2luZy10ZXN0L2FnZW50cy9MaW5raW5nIFRlc3QgSW1wbGVtZW50IEFnZW50L2FnZW50Lm1kIiwibGlua2luZy10ZXN0L2FnZW50cy9MaW5raW5nIFRlc3QgUmV2aWV3IEFnZW50L2FnZW50Lm1kIiwibGlua2luZy10ZXN0L2FnZW50cy9MaW5raW5nIFRlc3QgU3BlYyBBZ2VudC9hZ2VudC5tZCIsImxpbmtpbmctdGVzdC9hZ2VudHMvTGlua2luZyBUZXN0IFRyaWFnZSBBZ2VudC9hZ2VudC5tZCIsImxpbmtpbmctdGVzdC9hdXRvbWF0aW9ucy9naXRodWItZmFjdG9yeS1tZW50aW9uLWFzc2lnbi9hdXRvbWF0aW9uLm1kIiwibGlua2luZy10ZXN0L2F1dG9tYXRpb25zL2dpdGh1Yi1pc3N1ZS1sYWJlbGVkL2F1dG9tYXRpb24ubWQiLCJsaW5raW5nLXRlc3QvYXV0b21hdGlvbnMvZ2l0aHViLXByLWNsb3NlZC1vci1tZXJnZWQvYXV0b21hdGlvbi5tZCIsImxpbmtpbmctdGVzdC9hdXRvbWF0aW9ucy9naXRodWItcHItbGFiZWxlZC9hdXRvbWF0aW9uLm1kIiwibGlua2luZy10ZXN0L2F1dG9tYXRpb25zL2dpdGh1Yi1wci1yZXZpZXctc3VibWl0dGVkL2F1dG9tYXRpb24ubWQiLCJsaW5raW5nLXRlc3QvZmFjdG9yeS55YW1sIiwibGlua2luZy10ZXN0L3J1bm5lcnMvZGVmYXVsdC55YW1sIiwibGlua2luZy10ZXN0L3Njb3JlcnMvQ29kZSBRdWFsaXR5L3Njb3Jlci5tZCIsImxpbmtpbmctdGVzdC9zY29yZXJzL0VmZmljaWVuY3kvc2NvcmVyLm1kIiwibGlua2luZy10ZXN0L3Njb3JlcnMvUHJvY2VkdXJlIENvbXBsaWFuY2Uvc2NvcmVyLm1kIiwibGlua2luZy10ZXN0L3Njb3JlcnMvVGFzayBDb21wbGlhbmNlL3Njb3Jlci5tZCIsImxpbmtpbmctdGVzdC9zY29yZXJzL1ZlcmJvc2l0eS9zY29yZXIubWQiLCJsaW5raW5nLXRlc3Qvc2tpbGxzL2NvZGUtcXVhbGl0eS9TS0lMTC5tZCIsImxpbmtpbmctdGVzdC9za2lsbHMvY29kZS1yZXZpZXcvU0tJTEwubWQiLCJsaW5raW5nLXRlc3Qvc2tpbGxzL2dpdGh1Yi9TS0lMTC5tZCIsImxpbmtpbmctdGVzdC9za2lsbHMvZ2l0aHViL3NjcmlwdHMvcmVzb2x2ZS10aHJlYWRzIiwibGlua2luZy10ZXN0L3NraWxscy91aS12ZXJpZmljYXRpb24vU0tJTEwubWQiXX0" -->
|
@warp-agent-staging[bot] I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![warp-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR adds a file-backed Warp Factory definition under linking-test, including agents, GitHub automations, scorers, shared skills, and a Linux runner. The Factory tree validates against the server-backed v1alpha1 parser, but the generated GitHub thread-resolution script has a pagination bug that can leave addressed review threads unresolved.
Concerns
linking-test/skills/github/scripts/resolve-threadsonly reads the first 100 GitHub review threads before resolving explicitly supplied thread IDs. On PRs with more than 100 threads, valid target IDs after the first page are reported as missing, so the workflow cannot fulfill its requirement to reply to and resolve addressed threads.
Verdict
Checks: Factory file validation passed with the server parser for v1alpha1; state-dependent apply checks were not run. No approved or repository spec context was provided.
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| query($owner: String!, $repo: String!, $pr: Int!) { | ||
| repository(owner: $owner, name: $repo) { | ||
| pullRequest(number: $pr) { | ||
| reviewThreads(first: 100) { |
There was a problem hiding this comment.
not found and leaves addressed feedback open. Query pageInfo/endCursor and page until every requested thread ID is found or the connection is exhausted.
This pull request adds your Factory's definition files. After it merges, reopen the Factory settings in Warp to finish linking this repository.