Repository navigation
Preserve native CU toolsets and explicit bootstrap model selections - #16591
Open
warp-agent-staging[bot] wants to merge 3 commits into
Open
warp-agent-staging[bot] wants to merge 3 commits into
warp-agent-staging[bot] wants to merge 3 commits into
Conversation
Contributor
Author
|
This PR was generated with Warp. Comment |
bnavetta
reviewed
Oct 21, 2026
…olsets # Conflicts: # Cargo.lock # Cargo.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Carry declared native computer-use toolsets explicitly through endpoint parameters, modal edits, storage and proto transport. Resolve CU selections through the existing model-preferences accessor, matching base-model behavior: an unavailable pane override falls back to the profile, then the CU default; explicit Auto remains distinct from inheritance.
This is the Warp transport portion of REMOTE-3606. Shared design and independent selection controls: https://github.com/warpdotdev/warp-server/pull/20458. Custom-model configuration/runtime: https://github.com/warpdotdev/warp-server/pull/20486 (upper layer of server stack #20487). Additive transport dependency: warpdotdev/warp-proto-apis#405. Deploy the server before enabling custom CU controls; this PR adds no desktop configuration editor.
Linked Issue
ready-to-specorready-to-implement. — Tracking uses Linear and the approved spec, not these GitHub labels.Testing
After merging current
masterand updating the protocol pin to1766ae05d1a6, targeted nextest runs passed: 93 AI API-key tests and 91 Warp custom-endpoint/model/modal/computer-use tests.cargo clippy -p ai -p warp --all-targets --tests -- -D warningsand final./script/formatpassed. The full workspace and real gateway/desktop action-execution path were not run.An additional standalone TUI test/Clippy attempt could not compile: untouched upstream
warpuiheadless/winitplatform::Delegateimplementations lackget_cursor_shape(E0046). The PR's TUI changes only initialize the new endpoint field in existing fixtures; TUI validation is not claimed as passing.CI is checked separately on the current revision; passing targeted local validation is not full workspace or desktop execution proof.
./script/run— Not run: the requester explicitly deferred real gateway/native action-execution and interruption/no-replay proof.Screenshots / Videos
The Alpha Factory CU model defaults and Triage agent recording shows the server PR's web controls on Linux with mocked APIs. No gateway route was tested. The first recording and first two screenshots are an obsolete baseline/wrong-route investigation, not candidate verification. Only the Alpha Factory recording and subsequent screenshots demonstrate this candidate's controls.
Requester-deferred verification
These decisions close only the two verification gates for handoff. They do not make those checks passed, establish a verified LiteLLM/OpenRouter route, waive required CI, approve the code, or authorize merging. The attached Linux/MSW recording remains partial web-control proof.
Computer-use video recordings (2)
Factory computer-use model controls: Inspecting Factory Agent defaults and per-agent configuration for the Computer use model field in the mocked Factory web app.
Alpha Factory CU model defaults and Triage agent: Opens Computer use model choices in Alpha Factory agent defaults, saves a custom default, then inspects and saves Auto on the Triage agent and checks Claude Code harness visibility.
Computer-use screenshots (7)
Baseline Factory Settings > Agent defaults (Harness Warp, Default model Auto, Host Warp hosted, Runner unselected, Secrets, MCPs)
New Agent form (Warp harness) shows Harness/Model/Host/Runner but no Computer use model field
Alpha Factory (/factory/alpha) CU model list: Auto, Claude Sonnet 4.5, Team CU model · Team gateway, disabled "Unavailable CU model — Disabled by team policy"
Saved custom CU default "Team CU model · Team gateway · ANTHROPIC_CO..." after navigating away and back in Alpha Factory agent defaults
Triage agent (/factory/alpha/agents/agent-triage) CU choices: Use Factory default (...), Auto, Claude Sonnet 4.5, Team CU model, disabled Unavailable row
Triage agent after save showing explicit Computer use model "Auto"
Triage agent with Harness temporarily set to Claude Code: Auth, Model "From environment", no Computer use model field
Agent Mode
CHANGELOG-IMPROVEMENT: Preserve native computer-use toolset configuration through custom endpoint edits and requests.