Repository navigation
fix(cli-agent): keep Kiro multiline input visible - #16635
hengliu0919 wants to merge 3 commits into
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @hengliuz-code on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @hengliuz-code on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
|
@cla-bot check |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @hengliuz-code on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @hengliuz-code on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
Description
Problem
Warp's first-class Kiro integration enables the coding-agent footer for Kiro sessions. Kiro V3 renders a live prompt that grows toward the bottom of the terminal; on Warp
v0.2026.10.14.08.27.stable_01for macOS, repeated Shift+Enter input descends behind the footer and hides the cursor line.Kiro already decodes the relevant terminal encodings, including Ctrl+J, CSI-u Shift+Enter, xterm modifyOtherKeys, and ESC-prefixed Enter. The incompatible behavior begins at Warp's footer insertion boundary.
What changes
This is intentionally narrow: no terminal detection, input rewriting, global footer switch, or behavior change for other CLI agents.
Decision and tradeoff
The fix restores the viewport ownership Kiro had before Warp added first-class Kiro footer support. Kiro sessions temporarily lose Warp's coding-agent toolbar, but their self-rendered prompt retains all terminal rows and can scroll correctly.
The alternative of changing Kiro's input height or decoder was rejected because the exact reported Kiro nightly and current Kiro tests already handle all relevant key sequences. Disabling the footer broadly was rejected because other supported agents use bounded composers and retain compatible footer behavior.
Linked Issue
Follow-up to #9066 and #16243.
ready-to-specorready-to-implement.Testing
cargo test -p warp cli_agent_footer_does_not_render_for_kiro_session -- --nocapturecargo test -p warp test_warp_tui_variant_properties -- --nocapturecargo clippy -p warp --lib --tests -- -D warnings./script/formatcargo build -p warp --bin warp-oss2.33.1-nightly.3, real Shift+Return key events.hello, 4 newlines,new line, 4 newlines,asdfasdf, 4 newlines,asdfsaf.deep-marker-visibleremained visible.v0.2026.09.30.08.29.stable_03: before first-class Kiro support; no footer.v0.2026.10.07.08.29.stable_03: first release with Kiro integration/footer.v0.2026.10.21.08.25.stable_02: footer still present.The repository has no
pr-check:quickcommand, so the targeted tests, Clippy, formatter, and OSS build above were used../script/runThe fix was manually tested using the locally built
warp-ossbinary instead.Screenshots / Videos
Limitation: the original macOS failure was directly verified from the reporter's recording. The after-fix build was exercised on Linux/X11 because a macOS test host was unavailable. Released Linux builds did not reproduce the overlap, so the macOS-specific rendering surface is inferred from the direct recording, release boundary, and source behavior.
Agent Mode
CHANGELOG-BUG-FIX: Fixed Kiro CLI multiline prompts being hidden behind Warp's coding-agent toolbar.