Repository navigation
Spec: per-directory command history (GH5336) - #16636
Open
edgardmello wants to merge 1 commit into
Open
edgardmello wants to merge 1 commit into
edgardmello wants to merge 1 commit into
Conversation
Product and tech spec for scoping up-arrow command history to the current working directory, per issue warpdotdev#5336 (label: ready-to-spec). Co-Authored-By: Warp <agent@warp.dev>
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @edgardmello on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the product and tech spec for per-directory command history (issue #5336, labeled
ready-to-spec): an opt-in mode where up/down arrow command history is scoped to the current working directory, with aCtrl+Gtoggle back to global history, mirroring the zshper-directory-historyplugin referenced in the issue.Key points of the proposal:
History::up_arrow_suggestions_for_terminal_surface), so the GUI inline history menu, GUI history search, and TUI history menu all behave identically.directory_scoped_historysetting (default off), persisted and cloud-synced like other input settings.HistoryEntryalready recordspwdfor Warp-executed commands, so no storage/schema changes are needed; v1 matches pwd strings exactly.Ctrl+Gtoggle follows theInsertLastWordPrevCommandaction/binding precedent.Discussion on the design is welcome here — this PR is the home for product/technical review per the contributing guide. Once the specs are approved, implementation continues on this same PR.
Linked Issue
ready-to-specorready-to-implement→ Per directory history #5336 (ready-to-spec).Testing
N/A — this PR contains only specification documents (
specs/GH5336/product.md,specs/GH5336/tech.md); there are no runtime code changes. The planned unit tests and manual validation steps (each mapped to a numbered product invariant) are specified inspecs/GH5336/tech.md("Testing and validation") and will be executed as part of the implementation on this PR after spec approval../script/run→ N/A (docs-only)Agent Mode
Co-Authored-By: Warp agent@warp.dev