Repository navigation
Fix chat input cursor reset on empty AI selections - #16642
shortontech wants to merge 1 commit into
Conversation
Only reset the mouse cursor for non-empty AI block selections so clicking the chat input preserves its I-beam. Cover empty, non-empty, and cleared selections with cursor assertions. Refs: warpdotdev#16641 Co-Authored-By: Warp <agent@warp.dev>
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @shortontech on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
github-actions
Bot
added
the
external-contributor
|
@cla-bot check |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @shortontech on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Getting the following error attempting to sign the cla.
I don't suppose there's some verbal agreement I can leave here? |
|
@cla-bot check |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @shortontech on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
|
The cla-bot has been summoned, and re-checked this pull request! |
Description
Preserve the chat input I-beam when an AI block receives an empty or cleared selection update. Move the unconditional cursor reset in AIBlockAction::SelectText inside the existing non-empty selection guard, retaining reset behavior for actual text selections.
Extend the AI selection regression with cursor assertions for empty, non-empty, and cleared selections. Expose the existing cursor getter through test-util. No temporary tracing is included.
Linked Issue
Closes #16641
ready-to-specorready-to-implement.Draft pending issue triage/readiness.
Testing
copy_selected_text_from_ai_block: failed before the fix (Arrow instead of IBeam), passed afterward.cargo +1.96.0 test --locked -p warp --features gui --lib copy_selected_text_from_ai_block— passed.cargo +1.96.0 test --locked -p warpui_core --lib elements::gui::hoverable::tests— 6 passed.git diff --checkpassed.cargo run --bin warp-oss --features gui; the reporter confirmed the agent/chat input cursor issue is fixed.Screenshots / Videos
Not attached.
Agent Mode
CHANGELOG-BUG-FIX: Preserve the text-selection mouse cursor when clicking the agent chat input.
Co-Authored-By: Warp agent@warp.dev
Help with the CLA would be appreciated.