Repository navigation
Fix status-bar history subscription accumulation - #16658
Merged
Merged
Conversation
Contributor
Author
|
This PR was generated with Warp. Comment |
harryalbert
approved these changes
Oct 27, 2026
Contributor
Author
|
@harryalbert, your GitHub account is not connected to Warp. Connect your GitHub account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Keep the agent status bar's history subscription constant as exchanges change. WarpUI owns subscriptions for the view's lifetime, so replacing a boxed exchange model does not remove its callback.
Handle output events in the existing lifetime subscription, using the current exchange IDs. Older exchanges no longer reprocess the current output or close its summarization dialog. Same-conversation invalidation and global usage notifications remain supported; other AI block subscribers are unchanged.
This addresses one source of growing main-thread work during long agent conversations, not the separate Markdown parsing and stream-draining hotspots.
Linked Issue
No separate issue for this narrowly scoped fix.
ready-to-specorready-to-implement. — Not applicable.Testing
CARGO_BUILD_JOBS=2 CARGO_PROFILE_DEV_DEBUG=0 cargo nextest run -p warp --lib -E 'test(ai::blocklist::block::status_bar::tests)': 16 passed.CARGO_BUILD_JOBS=2 CARGO_PROFILE_DEV_DEBUG=0 cargo clippy -p warp --all-targets --tests -- -D warnings: passed../script/format: passed, run last../script/run— Skipped per the requester's tests-only choice; no macOS beachball reproduction is claimed.Agent Mode