Skip to content

💥 feat!: require express 5 and upgrade runtime dependencies - #72

Merged
MatheusAndrade23 merged 6 commits into
mainfrom
feat/require-express-5
Oct 14, 2026
Merged

MatheusAndrade23 merged 6 commits into
mainfrom
feat/require-express-5

Conversation

@MatheusAndrade23

@MatheusAndrade23 MatheusAndrade23 commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Contexto

TIM-3679. No tim-network-adapter, o @pact-foundation/pact instala express@^5 na raiz. O framework declarava express@^4 como peer, então o npm aninhava uma cópia do framework em cada workspace. Cada cópia tinha seu próprio AsyncLocalStorage, e o x-correlation-id gravado pela unit não chegava aos clients do libs.

O que muda

  • Breaking change: os peers express e @types/express passam a ser ^5.0.0, e continuam opcionais. Serviços que usam controllers, middlewares ou auth-permission/express com express 4 precisam migrar para o express 5 antes de subir para a 1.0.0. Serviços com Fastify ou Hono não são afetados.
  • expressRegisterPermissionAuth: o middleware agora é async. Uma falha do validator (rejeição da promise) vai para o error handler pelo tratamento nativo de promises do express 5.
  • Dev deps: express@5.3.0 e @types/express@5.0.6.
  • Dependências de runtime: mathjs 14 → 15 e os minors uuid 11.1, hono 4.13, zod 4.6, date-fns 4.4, winston 3.19 e @fastify/rate-limit 11.2.1. Todas mantêm build CommonJS e suportam Node 20.
  • Versão: 1.0.0. É uma breaking change, então sobe o major (semver, conforme o AGENTS.md).

Impacto nos consumidores

Serviço framework express
wave-usage-api ^0.16.0 ^4.21.2
wave-experience-api ^0.1.3 ^4.18.2
telcel-journeys-bff ^0.1.3 ^4.22.1
telcel-omni-hub-api ^0.1.3 ^4.21.2
wave-offers-api ^0.1.3 ^4.21.2

Nenhum deles quebra agora, porque o caret (^0.x) não pega a 1.0.0. Eles só precisam migrar para o express 5 quando subirem o framework. No tim-network-adapter, o bump fica no TIM-3729.

Como testar

  • pnpm lint, pnpm build e pnpm test (260 testes) passam com express 5. A spec do expressRegisterPermissionAuth sobe um app express 5 real e cobre a falha do validator indo para o error handler (503/401).
  • Smoke test com o pacote gerado por npm pack:
    • Num consumidor com express@5, o npm deixa uma única cópia do express (express@5.3.0 deduped sob o framework). O tsc --strict passa, e a requisição devolve o x-correlation-id recebido. A rejeição async do validator chega ao error handler.
    • Num consumidor com express@4, o npm i falha com ERESOLVE no peer express@"^5.0.0".
    • No Node 20.0 e no 22.23, Uuid.fromSeed (uuid v5) e as funções monetárias (mathjs) do dist devolvem os mesmos valores da 0.17.1 publicada.

Decisões

Decisão Escolha Motivo
Faixa do peer do express Só ^5.0.0 (opção B do ticket) O framework passa a mirar uma versão só do express, sem manter compatibilidade de tipos e comportamento com o 4. O express 5 é a linha ativa, e o pact e os serviços novos já o exigem.
Escopo das atualizações Só dependências que continuam funcionando no Node 20 A google-auth-library 11 exige Node 22, e o uuid 12+ é só ESM (no build CJS só carrega a partir do Node 20.19). Por isso ficam na 9 e na 11. @dbos-inc/dbos-sdk 5 e @prisma/client 7 também ficam fora, porque pedem mudança de código (API de filas do DBOS; tipos do Prisma só a partir do client gerado). As ferramentas de dev não afetam os consumidores.
Versão 1.0.0 É uma breaking change, então sobe o major. Quem está em ^0.x não pega a mudança sem querer.

Depois do merge

Publicar a 1.0.0 e seguir o TIM-3729 no tim-network-adapter.

BREAKING CHANGE: express and @types/express peers are now ^5.0.0.
Services using controllers, middlewares or auth-permission/express on
express 4 must migrate to express 5 before upgrading.

The express permission middleware is now async and relies on express 5
forwarding rejected promises to the error handler.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T22:06:09.821083Z 6d1f5a9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MatheusAndrade23 MatheusAndrade23 changed the title 💥 feat!: require express 5 in the express peer dependency 💥 feat!: require express 5 in the express peer dependency (1.0.0) Oct 13, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MatheusAndrade23 MatheusAndrade23 self-assigned this Oct 14, 2026
BREAKING CHANGE: engines.node is now >=22.12.0. google-auth-library 11
requires node 22, and uuid 14 is ESM-only, loaded from the CJS build
through require(esm).

Upgrades google-auth-library 11, mathjs 15, uuid 14, hono 4.13,
zod 4.6, date-fns 4.4, winston 3.19 and @fastify/rate-limit 11.2.1.
CI drops node 20.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MatheusAndrade23 MatheusAndrade23 changed the title 💥 feat!: require express 5 in the express peer dependency (1.0.0) 💥 feat!: require express 5 and node 22.12, upgrade runtime dependencies Oct 14, 2026
MatheusAndrade23 and others added 2 commits October 14, 2026 11:26
Upgrades mathjs 15, uuid 11.1, hono 4.13, zod 4.6, date-fns 4.4,
winston 3.19 and @fastify/rate-limit 11.2.1. All keep a CommonJS build
and support node 20.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MatheusAndrade23 MatheusAndrade23 changed the title 💥 feat!: require express 5 and node 22.12, upgrade runtime dependencies 💥 feat!: require express 5 and upgrade runtime dependencies Oct 14, 2026
@MatheusAndrade23
MatheusAndrade23 merged commit 1200c74 into main Oct 14, 2026
6 checks passed
@MatheusAndrade23
MatheusAndrade23 deleted the feat/require-express-5 branch October 14, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants