Skip to content

changed the crop slider increments from 1% to 0.1% for better accuracy - #837

Open
loudinthecloud wants to merge 1 commit into
webadderallorg:mainfrom
loudinthecloud:feature/finer-crop-increments
Open

changed the crop slider increments from 1% to 0.1% for better accuracy#837
loudinthecloud wants to merge 1 commit into
webadderallorg:mainfrom
loudinthecloud:feature/finer-crop-increments

Conversation

@loudinthecloud

@loudinthecloud loudinthecloud commented Aug 26, 2026

Copy link
Copy Markdown

Pull Request Template

Description

changed the crop slider increments from 1% to 0.1%

Motivation

Better precision, more polished looks of the final result

Type of Change

  • New Feature
  • Bug Fix
  • Refactor / Code Cleanup
  • Documentation Update
  • Other (please specify)

Related Issue(s)

Screenshots / Video

Screenshot (if applicable):

image

Testing Guide

Change sliders to get accurate results

Checklist

  • I have performed a self-review of my code.
  • I have added any necessary screenshots or videos.
  • I have linked related issue(s) and updated the changelog if applicable.

Thank you for contributing!

Summary by CodeRabbit

  • Enhancements
    • Crop controls now support more precise adjustments in 0.1% increments.
    • Crop values are displayed consistently with one decimal place.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: bc2cfb71-92ef-4454-a203-ae4551a0c482

📥 Commits

Reviewing files that changed from the base of the PR and between c701019 and 392fc15.

📒 Files selected for processing (1)
  • src/components/video-editor/SettingsPanel.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

Changes

Crop precision controls

Layer / File(s) Summary
Crop calculation and slider precision
src/components/video-editor/SettingsPanel.tsx
Crop inset calculations round percentages to one decimal place. All crop sliders use 0.1 steps and display one decimal place.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 392fc

This PR makes the crop slider more precise by changing increments from 1% to 0.1%; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: webadderall, joehachemx, surim0n

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: crop slider increments now use 0.1% instead of 1% for improved precision.
Description check ✅ Passed The description includes the required sections, explains the motivation, identifies the change type, provides a screenshot, and includes a testing guide. The testing steps are brief, but they are suff…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes the required sections, explains the motivation, identifies the change type, provides a screenshot, and includes a testing guide. The testing steps are brief, but they are sufficient for this small UI change.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant