Skip to content

Fix HUD overlay blocking the screen while recording #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
datasciritwik wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix HUD overlay blocking the screen while recording #845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion electron/windows.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,9 +182,16 @@ function getHudOverlayBounds() {
recordingActive: hudOverlayRecordingActive,
webcamPreviewVisible: hudOverlayWebcamPreviewVisible,
});
// The fallback geometry is a fixed, solid block sized for platforms that
// cannot make the overlay click-through. Using it while recording on a
// platform that *can* pass clicks through leaves a large real window sitting
// over the screen: the OS window picker (Cmd+Shift+5) highlights and selects
// the HUD instead of the app behind it, and any moment the renderer holds the
// mouse the whole block swallows clicks. Passthrough support is a property
// of the platform, not of whether a recording is in progress.
return getHudOverlayWindowBounds(
workArea,
isHudOverlayMousePassthroughSupported() && !hudOverlayRecordingActive,
isHudOverlayMousePassthroughSupported(),
fallbackExpanded,
);
}
Expand Down