Fabric 26.x support#4263
Open
reusteur73 wants to merge 11 commits into
Open
Conversation
|
seems to work fine on 26.2 as well, I just edited the json and recomped, threw it on my server to check. everything seems to work fine for me, and im having no errors in the console. |
Contributor
Contributor
Author
|
Yep, thanks for the feedback! The problem was indeed this: float tmp = bb.getBaseTemperature(), hum = 0.0f; // set humidity later?(DynmapPlugin.java:340) I implemented a fix and removed the unnecessary mixins. |
Contributor
|
Thanks for the quick fix. I tested and it's working on my test server now. Will be updating my main server today. Probably should have reported it to you sooner, but it took a while for us to notice after updating to 26.1. I don't know if I ever would have checked that spot you did for the fix lol. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR builds on top of taranovegor's PR and adds further support for Minecraft 26.1+ (Fabric)
Suggestion: Please merge @taranovegor's PR first, this one includes all his changes plus the additions below.
Added on top of @taranovegor 's work:
Showcase