Repository navigation
chore: point the integration tests at 127.0.0.1, not the compose service - #88
Merged
Merged
Conversation
phpunit.xml.dist defaulted the MySQL host env var to the compose service name, which only resolves inside a compose network. The host value the fleet settled on is 127.0.0.1, the address compose publishes on 3306. webware-ci.json already supplies 127.0.0.1 to CI, so this changes local runs only, where the service-name default made the integration tests fail to connect. Signed-off-by: Joey Smith <jsmith@webinertia.net>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
phpunit.xml.distdefaulted the MySQL host env var to the compose service name (mysql), which only resolves inside a compose network. The fleet host value is127.0.0.1, the address compose publishes on 3306.webware-ci.jsonalready supplies127.0.0.1to CI, so this changes local runs only - where the service-name default made the integration tests fail to connect.