Repository navigation
fix: align the log table collation with the rest of the fleet - #93
Merged
Merged
Conversation
The log table was created with utf8mb4_general_ci while acl_role, acl_rule, user and the session table all declare utf8mb4_0900_ai_ci. Any query comparing a log string column to another table's string column raises "Illegal mix of collations"; log.user_identifier against a user identity column is the concrete case. Sets the table collation to utf8mb4_0900_ai_ci - the MySQL 8+ server default and what the sibling packages already declare - and updates the integration fixture and the unit assertions that pinned the old literal. Signed-off-by: Joey Smith <jsmith@webinertia.net> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Joey Smith <jsmith@webinertia.net>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The log table is created with
utf8mb4_general_ciwhileacl_role,acl_rule,userand the session table all declareutf8mb4_0900_ai_ci. Any query comparing alogstring column to another table's string column raisesIllegal mix of collations;log.user_identifieragainst a user identity column is the concrete case.Changes
src/Console/Schema/LogSchema.php- table collation toutf8mb4_0900_ai_citest/integration/TestFixtures/mysql.sql- the same collation on the six string columns and the table option, so the fixture matches what the schema emitstest/unit/Console/Schema/LogSchemaTest.php- the three assertions that pinned the old literalVerification
composer teston PHP 8.5.11: 100 tests, 179 assertions, OK. Mago gates run in CI only - no mago binary is vendored locally.